Commit 614571a8 authored by Fabien Potencier's avatar Fabien Potencier

made the terminate implementation more consistent with other event implementations

parent c9dc3f49
...@@ -431,6 +431,14 @@ class Application extends \Pimple implements HttpKernelInterface, EventSubscribe ...@@ -431,6 +431,14 @@ class Application extends \Pimple implements HttpKernelInterface, EventSubscribe
return $this['kernel']->handle($request, $type, $catch); return $this['kernel']->handle($request, $type, $catch);
} }
/**
* {@inheritdoc}
*/
public function terminate(Request $request, Response $response)
{
$this['kernel']->terminate($request, $response);
}
/** /**
* Handles onEarlyKernelRequest events. * Handles onEarlyKernelRequest events.
* *
...@@ -501,14 +509,13 @@ class Application extends \Pimple implements HttpKernelInterface, EventSubscribe ...@@ -501,14 +509,13 @@ class Application extends \Pimple implements HttpKernelInterface, EventSubscribe
} }
/** /**
* Runs finish filters, TerminableInterface implementation * Runs finish filters.
* *
* @param Request $request * Handler for onKernelTerminate.
* @param Response $response
*/ */
public function terminate(Request $request, Response $response) public function onKernelTerminate(PostResponseEvent $event)
{ {
$this['dispatcher']->dispatch(SilexEvents::FINISH, new PostResponseEvent($this, $request, $response)); $this['dispatcher']->dispatch(SilexEvents::FINISH, $event);
} }
/** /**
...@@ -547,6 +554,7 @@ class Application extends \Pimple implements HttpKernelInterface, EventSubscribe ...@@ -547,6 +554,7 @@ class Application extends \Pimple implements HttpKernelInterface, EventSubscribe
KernelEvents::CONTROLLER => 'onKernelController', KernelEvents::CONTROLLER => 'onKernelController',
KernelEvents::RESPONSE => 'onKernelResponse', KernelEvents::RESPONSE => 'onKernelResponse',
KernelEvents::EXCEPTION => 'onKernelException', KernelEvents::EXCEPTION => 'onKernelException',
KernelEvents::TERMINATE => 'onKernelTerminate',
KernelEvents::VIEW => array('onKernelView', -10), KernelEvents::VIEW => array('onKernelView', -10),
); );
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment