Commit fde7db80 authored by Fabien Potencier's avatar Fabien Potencier

Merge branch '1.2' into 1.3

* 1.2:
  Phpdocs
parents 938a3e9c 2038b91c
...@@ -43,9 +43,6 @@ class ControllerCollection ...@@ -43,9 +43,6 @@ class ControllerCollection
protected $defaultController; protected $defaultController;
protected $prefix; protected $prefix;
/**
* Constructor.
*/
public function __construct(Route $defaultRoute) public function __construct(Route $defaultRoute)
{ {
$this->defaultRoute = $defaultRoute; $this->defaultRoute = $defaultRoute;
......
...@@ -100,7 +100,7 @@ class LogListener implements EventSubscriberInterface ...@@ -100,7 +100,7 @@ class LogListener implements EventSubscriberInterface
/** /**
* Logs an exception. * Logs an exception.
* *
* @param Exception $e * @param \Exception $e
*/ */
protected function logException(\Exception $e) protected function logException(\Exception $e)
{ {
......
...@@ -31,6 +31,7 @@ class ExceptionListenerWrapper ...@@ -31,6 +31,7 @@ class ExceptionListenerWrapper
* Constructor. * Constructor.
* *
* @param Application $app An Application instance * @param Application $app An Application instance
* @param callable $callback
*/ */
public function __construct(Application $app, $callback) public function __construct(Application $app, $callback)
{ {
......
...@@ -28,12 +28,12 @@ use Symfony\Component\Serializer\Normalizer\GetSetMethodNormalizer; ...@@ -28,12 +28,12 @@ use Symfony\Component\Serializer\Normalizer\GetSetMethodNormalizer;
class SerializerServiceProvider implements ServiceProviderInterface class SerializerServiceProvider implements ServiceProviderInterface
{ {
/** /**
* {@inheritDoc} * {@inheritdoc}
* *
* This method registers a serializer service. {@link http://api.symfony.com/master/Symfony/Component/Serializer/Serializer.html * This method registers a serializer service. {@link http://api.symfony.com/master/Symfony/Component/Serializer/Serializer.html
* The service is provided by the Symfony Serializer component}. * The service is provided by the Symfony Serializer component}.
* *
* @param Silex\Application $app * @param Application $app
*/ */
public function register(Application $app) public function register(Application $app)
{ {
...@@ -51,11 +51,11 @@ class SerializerServiceProvider implements ServiceProviderInterface ...@@ -51,11 +51,11 @@ class SerializerServiceProvider implements ServiceProviderInterface
} }
/** /**
* {@inheritDoc} * {@inheritdoc}
* *
* This provider does not execute any code when booting. * This provider does not execute any code when booting.
* *
* @param Silex\Application $app * @param Application $app
*/ */
public function boot(Application $app) public function boot(Application $app)
{ {
......
...@@ -22,7 +22,7 @@ use Symfony\Component\Routing\Matcher\RedirectableUrlMatcher as BaseRedirectable ...@@ -22,7 +22,7 @@ use Symfony\Component\Routing\Matcher\RedirectableUrlMatcher as BaseRedirectable
class RedirectableUrlMatcher extends BaseRedirectableUrlMatcher class RedirectableUrlMatcher extends BaseRedirectableUrlMatcher
{ {
/** /**
* @see RedirectableUrlMatcherInterface::match() * {@inheritdoc}
*/ */
public function redirect($path, $route, $scheme = null) public function redirect($path, $route, $scheme = null)
{ {
......
...@@ -39,7 +39,7 @@ class CallbackResolverTest extends \PHPUnit_Framework_Testcase ...@@ -39,7 +39,7 @@ class CallbackResolverTest extends \PHPUnit_Framework_Testcase
} }
/** /**
* @expectedException InvalidArgumentException * @expectedException \InvalidArgumentException
* @expectedExceptionMessage Service "some_service" does not exist. * @expectedExceptionMessage Service "some_service" does not exist.
*/ */
public function testShouldThrowAnExceptionIfServiceIsMissing() public function testShouldThrowAnExceptionIfServiceIsMissing()
......
...@@ -64,7 +64,7 @@ class CallbackServicesTest extends \PHPUnit_Framework_TestCase ...@@ -64,7 +64,7 @@ class CallbackServicesTest extends \PHPUnit_Framework_TestCase
public function controller(Application $app) public function controller(Application $app)
{ {
return $app->abort(404); $app->abort(404);
} }
public function before() public function before()
......
...@@ -31,7 +31,7 @@ class ControllerTest extends \PHPUnit_Framework_TestCase ...@@ -31,7 +31,7 @@ class ControllerTest extends \PHPUnit_Framework_TestCase
} }
/** /**
* @expectedException Silex\Exception\ControllerFrozenException * @expectedException \Silex\Exception\ControllerFrozenException
*/ */
public function testBindOnFrozenControllerShouldThrowException() public function testBindOnFrozenControllerShouldThrowException()
{ {
......
...@@ -40,7 +40,7 @@ class LazyUrlMatcherTest extends \PHPUnit_Framework_TestCase ...@@ -40,7 +40,7 @@ class LazyUrlMatcherTest extends \PHPUnit_Framework_TestCase
} }
/** /**
* @expectedException LogicException * @expectedException \LogicException
* @expectedExceptionMessage Factory supplied to LazyUrlMatcher must return implementation of UrlMatcherInterface. * @expectedExceptionMessage Factory supplied to LazyUrlMatcher must return implementation of UrlMatcherInterface.
*/ */
public function testThatCanInjectUrlMatcherOnly() public function testThatCanInjectUrlMatcherOnly()
......
...@@ -147,7 +147,7 @@ class MonologServiceProviderTest extends \PHPUnit_Framework_TestCase ...@@ -147,7 +147,7 @@ class MonologServiceProviderTest extends \PHPUnit_Framework_TestCase
} }
/** /**
* @expectedException InvalidArgumentException * @expectedException \InvalidArgumentException
* @expectedExceptionMessage Provided logging level 'foo' does not exist. Must be a valid monolog logging level. * @expectedExceptionMessage Provided logging level 'foo' does not exist. Must be a valid monolog logging level.
*/ */
public function testNonExistentStringErrorLevel() public function testNonExistentStringErrorLevel()
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment