Commits
-------

58fc60f3 Adds doc about proxy headers trust

Discussion
----------

Adds doc about proxy headers trust

---------------------------------------------------------------------------

by igorw at 2011/12/21 07:07:57 -0800

No instantiation needed, just call it statically on the request class:

    Request::trustProxyData();

If there is something about this in the Symfony2 docs, it'd be nice to link to it.

---------------------------------------------------------------------------

by marcw at 2011/12/21 07:19:53 -0800

Well this is a configuration parameter in Symfony2...

Commits
-------

604b9177 [docs] set detect_unicode=off, so phar:// is no longer needed

Discussion
----------

[docs] set detect_unicode=off, so phar:// is no longer needed

detect_unicode was causing some issues with wrongly detecting the encoding. This is one of the reasons that phar:// was required, but I am not sure if this is the only case. I will leave the "phar-stub bug" section there for now.

Commits
-------

2434ad91 [doc] proofread documentation and fixed some typos.

Discussion
----------

[doc] proofread documentation and fixed some typos.

---------------------------------------------------------------------------

by igorw at 2011/11/10 05:30:58 -0800

Thumbs up!

Commits
-------

3871f24c [DoctrineServiceProvider] Fix default options was not used with tests

Discussion
----------

[DoctrineServiceProvider] Fix default options was not used

---------------------------------------------------------------------------

by fabpot at 2011/10/25 23:13:23 -0700

The code looks correct to as we are modifying the options by reference.

---------------------------------------------------------------------------

by jeromemacias at 2011/10/26 05:54:18 -0700

On the line 50 :

```php
$tmp = $app['dbs.options'];
```

This is a copy of options array, the reference used after does not has any effect on initial options array.

---------------------------------------------------------------------------

by DrBenton at 2011/10/26 06:02:46 -0700

@jeromemacias But in the ``` foreach ($tmp as $name => &$options) ``` the ```$options``` var is referenced (with the use of ```&```), not copied.
Thus, if I'm not wrong, this loop *does* have an effect on ```$app['dbs.options']```.

---------------------------------------------------------------------------

by jeromemacias at 2011/10/26 12:36:40 -0700

@DrBenton The $options var is a reference to $tmp but $tmp is a copy of $apps['dbs.options'],  not a reference.

---------------------------------------------------------------------------

by jeromemacias at 2011/10/26 12:58:38 -0700

I used this config (json) :

```json
{
  "db.options":
  {
    "dbname": "mydbname",
    "user": "mydbuser",
    "password": "mydbpass"
  }
}
```

With the current code :

```php
            $tmp = $app['dbs.options'];
            foreach ($tmp as $name => &$options) {
                $options = array_replace($app['db.default_options'], $options);

                if (!isset($app['dbs.default'])) {
                    $app['dbs.default'] = $name;
                }
            }

            var_export($app['dbs.options']); die;
```

The result is :

```php
array ( 'default' => array ( 'dbname' => 'mydbname', 'user' => 'mydbuser', 'password' => 'mydbpass', ), )
```

With the new code :

```php
            $tmp = $app['dbs.options'];
            foreach ($tmp as $name => &$options) {
                $options = array_replace($app['db.default_options'], $options);

                if (!isset($app['dbs.default'])) {
                    $app['dbs.default'] = $name;
                }
            }
            $app['dbs.options'] = $tmp;

            var_export($app['dbs.options']); die;
```

The result is :

```php
array ( 'default' => array ( 'driver' => 'pdo_mysql', 'dbname' => 'mydbname', 'host' => 'localhost', 'user' => 'mydbuser', 'password' => 'mydbpass', ), )
```

---------------------------------------------------------------------------

by igorw at 2011/10/26 13:59:51 -0700

Issue confirmed, please reopen and merge.

EDIT: To be clear: the defaults are not being applied to dbs.options.

---------------------------------------------------------------------------

by DrBenton at 2011/10/26 14:05:23 -0700

Sorry, you're right @jeromemacias. Since the values of ```$app['dbs.options']``` seem to be simple scalars, iterating though ```$tmp``` values, even by reference, does not affect ```$app['dbs.options']``` values. I thought ```$app['dbs.options']``` values where Objects (in that case, the code would have been ok).

My mistake !

---------------------------------------------------------------------------

by fabpot at 2011/10/26 14:13:41 -0700

We need some unit tests for this.

---------------------------------------------------------------------------

by jeromemacias at 2011/10/30 09:28:53 -0700

@fabpot Just added test

---------------------------------------------------------------------------

by fabpot at 2011/11/07 01:08:44 -0800

Can you squash your commits? Thanks.

---------------------------------------------------------------------------

by jeromemacias at 2011/11/07 15:18:40 -0800

@fabpot Done.

Commits
-------

554425d7 maintain line numbers when minifying php for the phar

Discussion
----------

maintain line numbers when minifying php for the phar

Currently the minification of a phar makes debugging impossible. This PR adds newlines to keep the line numbers intact.

Commits
-------

79e2684f [Silex] use @inheritdoc instead of a new phpdoc block.
46dc1dff [Silex] added missing PHPDoc blocks.

Discussion
----------

[Silex] added missing PHPDoc blocks.

Commits
-------

b711b707 [MonologServiceProvider] improve logging, log reponse status, improve test granularity

Discussion
----------

[MonologServiceProvider] improve logging, log response status, improve test granularity

Commits
-------

d53661a1 [composer] add autoload information

Discussion
----------

[composer] add autoload information

Commits
-------

1b1ce148 small correction in the configuration array

Discussion
----------

Small correction in the configuration array of DoctrineProvider

Netbeans just complained about missing comma.

Commits
-------

43ae6965 fix comment in LazyUrlMatcher
4d5ffca8 add test case for late listeners
51df9f5a Create default set of listeners late

Discussion
----------

Create default set of listeners late

Right now the following subscribers are created together with the
dispatcher:

* app
* exception_handler
* ResponseListener
* RouterListener

With the exception_handler in particular this is an issue because you
can no longer change it after the dispatcher has been created. And it
gets created when you call before(), after() or error(). It means that
you cannot unset it for tests.

The RouterListener has a similar issue because you can no longer change
the UrlMatcher it uses. And you cannot move its creation into a request
listener, because request listeners cannot add other request listeners
(the new ones won't get executed anymore at that point).

This commit ensures that those listeners will be created a lot later,
allowing their dependencies to be modified before runtime.

Commits
-------

81576415 Matching multiple methods with one controller, see http://groups.google.com/group/silex-php/browse_thread/thread/5f3b3d791c337845

Discussion
----------

Matching multiple methods with one controller, see http://groups.google.c

Matching multiple methods with one controller, see http://groups.google.com/group/silex-php/browse_thread/thread/5f3b3d791c337845

Right now the following subscribers are created together with the
dispatcher:

* app
* exception_handler
* ResponseListener
* RouterListener

With the exception_handler in particular this is an issue because you
can no longer change it after the dispatcher has been created. And it
gets created when you call before(), after() or error(). It means that
you cannot unset it for tests.

The RouterListener has a similar issue because you can no longer change
the UrlMatcher it uses. And you cannot move its creation into a request
listener, because request listeners cannot add other request listeners
(the new ones won't get executed anymore at that point).

This commit ensures that those listeners will be created a lot later,
allowing their dependencies to be modified before runtime.

Matching multiple methods with one controller, see http://groups.google.com/group/silex-php/browse_thread/thread/5f3b3d791c337845

Commits
-------

ef75e13b add a prefix to defaultRouteName to prevent route name conflicts

Discussion
----------

add a prefix to defaultRouteName to prevent route name conflicts

* closes #189
* identical route names no longer conflict when merging RouteCollections
* route names are automatically generated by
  Controller::bindDefaultRouteName

Commits
-------

16a86e06 Connect method does not exist in Silex\Application

Discussion
----------

Documentation fix

Connect method does not exists in providers doc ; but mount exists and this is the one expected in the example

Commits
-------

01a0f12c Updating the `SymfonyBridgesServiceProvider` documentation with using the `TwigBridge` subtree split.

Discussion
----------

Added `TwigBridge` reference to `SymfonyBridgesServiceProvider` documentation

Updated the `SymfonyBridgesServiceProvider` documentation with suggestion on using the `TwigBridge` subtree split.

This has a much smaller footprint when doing deployments and packaging the application for 3rd parties.

Updating the `SymfonyBridgesServiceProvider` documentation with using the `TwigBridge` subtree split.

This has a much smaller footprint when doing deployments and packaging the application for 3rd parties.

* closes #189
* identical route names no longer conflict when merging RouteCollections
* route names are automatically generated by
  Controller::bindDefaultRouteName