Merge pull request #487 from thePanz/patch-1

Keep Response statusCode as integer, not string

library/Solarium/Core/Client/Response.php

@@ -157,7 +157,7 @@ class Response
         // $statusInfo[1] = the HTTP response code
         // $statusInfo[2] = the response message
         $statusInfo = explode(' ', $statusHeader, 3);
-        $this->statusCode = $statusInfo[1];
+        $this->statusCode = (int) $statusInfo[1];
         $this->statusMessage = $statusInfo[2];
     }
 }

tests/Solarium/Tests/Core/Client/Adapter/Guzzle3Test.php

@@ -89,7 +89,7 @@ final class Guzzle3Test extends \PHPUnit_Framework_TestCase
 
         $response = $this->adapter->execute($request, $endpoint);
         $this->assertSame('OK', $response->getStatusMessage());
-        $this->assertSame('200', $response->getStatusCode());
+        $this->assertSame(200, $response->getStatusCode());
         $this->assertSame(
             array(
                 'HTTP/1.1 200 OK',
@@ -136,7 +136,7 @@ final class Guzzle3Test extends \PHPUnit_Framework_TestCase
 
         $response = $this->adapter->execute($request, $endpoint);
         $this->assertSame('OK', $response->getStatusMessage());
-        $this->assertSame('200', $response->getStatusCode());
+        $this->assertSame(200, $response->getStatusCode());
         $this->assertSame(
             array(
                 'HTTP/1.1 200 OK',
@@ -185,7 +185,7 @@ final class Guzzle3Test extends \PHPUnit_Framework_TestCase
 
         $response = $this->adapter->execute($request, $endpoint);
         $this->assertSame('OK', $response->getStatusMessage());
-        $this->assertSame('200', $response->getStatusCode());
+        $this->assertSame(200, $response->getStatusCode());
         $this->assertSame(
             array(
                 'HTTP/1.1 200 OK',
@@ -237,7 +237,7 @@ final class Guzzle3Test extends \PHPUnit_Framework_TestCase
 
         $response = $this->adapter->execute($request, $endpoint);
         $this->assertSame('OK', $response->getStatusMessage());
-        $this->assertSame('200', $response->getStatusCode());
+        $this->assertSame(200, $response->getStatusCode());
         $this->assertSame(
             array(
                 'HTTP/1.1 200 OK',

tests/Solarium/Tests/Core/Client/Adapter/GuzzleTest.php

@@ -94,7 +94,7 @@ final class GuzzleAdapterTest extends \PHPUnit_Framework_TestCase
 
         $response = $adapter->execute($request, $endpoint);
         $this->assertSame('OK', $response->getStatusMessage());
-        $this->assertSame('200', $response->getStatusCode());
+        $this->assertSame(200, $response->getStatusCode());
         $this->assertSame(
             array(
                 'HTTP/1.1 200 OK',
@@ -141,7 +141,7 @@ final class GuzzleAdapterTest extends \PHPUnit_Framework_TestCase
 
         $response = $adapter->execute($request, $endpoint);
         $this->assertSame('OK', $response->getStatusMessage());
-        $this->assertSame('200', $response->getStatusCode());
+        $this->assertSame(200, $response->getStatusCode());
         $this->assertSame(
             array(
                 'HTTP/1.1 200 OK',
@@ -190,7 +190,7 @@ final class GuzzleAdapterTest extends \PHPUnit_Framework_TestCase
 
         $response = $adapter->execute($request, $endpoint);
         $this->assertSame('OK', $response->getStatusMessage());
-        $this->assertSame('200', $response->getStatusCode());
+        $this->assertSame(200, $response->getStatusCode());
         $this->assertSame(
             array(
                 'HTTP/1.1 200 OK',
@@ -239,7 +239,7 @@ final class GuzzleAdapterTest extends \PHPUnit_Framework_TestCase
 
         $response = $adapter->execute($request, $endpoint);
         $this->assertSame('OK', $response->getStatusMessage());
-        $this->assertSame('200', $response->getStatusCode());
+        $this->assertSame(200, $response->getStatusCode());
         $this->assertSame(
             array(
                 'HTTP/1.1 200 OK',

tests/Solarium/Tests/Core/Client/Adapter/PeclHttpTest.php

@@ -211,7 +211,7 @@ EOF;
 
         $response = $mock->execute($request, $endpoint);
         $this->assertEquals($body, $response->getBody());
-        $this->assertEquals($statusCode, $response->getStatusCode());
+        $this->assertSame($statusCode, $response->getStatusCode());
         $this->assertEquals($statusMessage, $response->getStatusMessage());
     }