Commit eaf45495 authored by Bas de Nooijer's avatar Bas de Nooijer Committed by GitHub

Merge pull request #485 from tonynelson19/patch-1

Performance updates for formatting values
parents 520eb82a 6b799756
...@@ -229,10 +229,6 @@ class RequestBuilder extends BaseRequestBuilder ...@@ -229,10 +229,6 @@ class RequestBuilder extends BaseRequestBuilder
*/ */
protected function buildFieldXml($name, $boost, $value, $modifier = null, $query = null) protected function buildFieldXml($name, $boost, $value, $modifier = null, $query = null)
{ {
if ($value instanceof \DateTime) {
$value = $query->getHelper()->formatDate($value);
}
$xml = '<field name="' . $name . '"'; $xml = '<field name="' . $name . '"';
$xml .= $this->attrib('boost', $boost); $xml .= $this->attrib('boost', $boost);
$xml .= $this->attrib('update', $modifier); $xml .= $this->attrib('update', $modifier);
...@@ -242,10 +238,13 @@ class RequestBuilder extends BaseRequestBuilder ...@@ -242,10 +238,13 @@ class RequestBuilder extends BaseRequestBuilder
$value = 'false'; $value = 'false';
} elseif ($value === true) { } elseif ($value === true) {
$value = 'true'; $value = 'true';
} elseif ($value instanceof \DateTime) {
$value = $query->getHelper()->formatDate($value);
} else {
$value = htmlspecialchars($value, ENT_NOQUOTES, 'UTF-8');
} }
$xml .= '>' . htmlspecialchars($value, ENT_NOQUOTES, 'UTF-8'); $xml .= '>' . $value . '</field>';
$xml .= '</field>';
return $xml; return $xml;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment