Commit f9167c2a authored by Bas de Nooijer's avatar Bas de Nooijer

Fix for issue #158

parent 2b3eb876
...@@ -59,7 +59,12 @@ abstract class RequestBuilder implements RequestBuilderInterface ...@@ -59,7 +59,12 @@ abstract class RequestBuilder implements RequestBuilderInterface
$request->setHandler($query->getHandler()); $request->setHandler($query->getHandler());
$request->addParam('omitHeader', $query->getOmitHeader()); $request->addParam('omitHeader', $query->getOmitHeader());
$request->addParams($query->getParams()); $request->addParams($query->getParams());
$request->addParam('wt', $query->getResponseWriter()); $request->addParam('wt', $query->getResponseWriter());
if ($query->getResponseWriter() == $query::WT_JSON) {
// only one JSON format is supported
$request->addParam('json.nl', 'flat');
}
return $request; return $request;
} }
......
...@@ -68,7 +68,7 @@ class RequestBuilderTest extends \PHPUnit_Framework_TestCase ...@@ -68,7 +68,7 @@ class RequestBuilderTest extends \PHPUnit_Framework_TestCase
$request = $this->builder->build($query); $request = $this->builder->build($query);
$this->assertEquals( $this->assertEquals(
'select?omitHeader=false&p1=v1&p2=v2&wt=json', 'select?omitHeader=false&p1=v1&p2=v2&wt=json&json.nl=flat',
urldecode($request->getUri()) urldecode($request->getUri())
); );
} }
......
...@@ -68,6 +68,7 @@ class RequestBuilderTest extends \PHPUnit_Framework_TestCase ...@@ -68,6 +68,7 @@ class RequestBuilderTest extends \PHPUnit_Framework_TestCase
'wt' => 'json', 'wt' => 'json',
'analysis.query' => $query, 'analysis.query' => $query,
'analysis.showmatch' => 'true', 'analysis.showmatch' => 'true',
'json.nl' => 'flat',
'omitHeader' => 'true', 'omitHeader' => 'true',
), ),
$request->getParams() $request->getParams()
......
...@@ -79,7 +79,7 @@ class RequestBuilderTest extends \PHPUnit_Framework_TestCase ...@@ -79,7 +79,7 @@ class RequestBuilderTest extends \PHPUnit_Framework_TestCase
{ {
$request = $this->builder->build($this->query); $request = $this->builder->build($this->query);
$this->assertEquals( $this->assertEquals(
'update/extract?omitHeader=true&param1=value1&wt=json&fmap.from-field=to-field&resource.name=RequestBuilderTest.php', 'update/extract?omitHeader=true&param1=value1&wt=json&json.nl=flat&fmap.from-field=to-field&resource.name=RequestBuilderTest.php',
$request->getUri() $request->getUri()
); );
} }
...@@ -103,6 +103,7 @@ class RequestBuilderTest extends \PHPUnit_Framework_TestCase ...@@ -103,6 +103,7 @@ class RequestBuilderTest extends \PHPUnit_Framework_TestCase
'param1' => 'value1', 'param1' => 'value1',
'resource.name' => 'RequestBuilderTest.php', 'resource.name' => 'RequestBuilderTest.php',
'wt' => 'json', 'wt' => 'json',
'json.nl' => 'flat',
), ),
$request->getParams() $request->getParams()
); );
......
...@@ -90,6 +90,7 @@ class RequestBuilderTest extends \PHPUnit_Framework_TestCase ...@@ -90,6 +90,7 @@ class RequestBuilderTest extends \PHPUnit_Framework_TestCase
'start' => 12, 'start' => 12,
'wt' => 'json', 'wt' => 'json',
'omitHeader' => 'true', 'omitHeader' => 'true',
'json.nl' => 'flat',
), ),
$request->getParams() $request->getParams()
); );
......
...@@ -43,7 +43,7 @@ class RequestBuilderTest extends \PHPUnit_Framework_TestCase ...@@ -43,7 +43,7 @@ class RequestBuilderTest extends \PHPUnit_Framework_TestCase
$request = $builder->build(new Query); $request = $builder->build(new Query);
$this->assertEquals( $this->assertEquals(
'admin/ping?omitHeader=true&wt=json', 'admin/ping?omitHeader=true&wt=json&json.nl=flat',
$request->getUri() $request->getUri()
); );
......
...@@ -50,7 +50,7 @@ class RequestBuilderTest extends \PHPUnit_Framework_TestCase ...@@ -50,7 +50,7 @@ class RequestBuilderTest extends \PHPUnit_Framework_TestCase
); );
$this->assertEquals( $this->assertEquals(
'get?omitHeader=true&wt=json&ids=123', 'get?omitHeader=true&wt=json&json.nl=flat&ids=123',
urldecode($request->getUri()) urldecode($request->getUri())
); );
} }
...@@ -68,7 +68,7 @@ class RequestBuilderTest extends \PHPUnit_Framework_TestCase ...@@ -68,7 +68,7 @@ class RequestBuilderTest extends \PHPUnit_Framework_TestCase
); );
$this->assertEquals( $this->assertEquals(
'get?omitHeader=true&wt=json&ids=123,456', 'get?omitHeader=true&wt=json&json.nl=flat&ids=123,456',
urldecode($request->getUri()) urldecode($request->getUri())
); );
} }
......
...@@ -74,7 +74,7 @@ class RequestBuilderTest extends \PHPUnit_Framework_TestCase ...@@ -74,7 +74,7 @@ class RequestBuilderTest extends \PHPUnit_Framework_TestCase
); );
$this->assertEquals( $this->assertEquals(
'select?omitHeader=true&wt=json&q=*:*&start=0&rows=10&fl=*,score', 'select?omitHeader=true&wt=json&json.nl=flat&q=*:*&start=0&rows=10&fl=*,score',
urldecode($request->getUri()) urldecode($request->getUri())
); );
} }
...@@ -91,7 +91,7 @@ class RequestBuilderTest extends \PHPUnit_Framework_TestCase ...@@ -91,7 +91,7 @@ class RequestBuilderTest extends \PHPUnit_Framework_TestCase
); );
$this->assertEquals( $this->assertEquals(
'select?omitHeader=true&wt=json&q=*:*&start=0&rows=10&fl=*,score&sort=id asc,name desc', 'select?omitHeader=true&wt=json&json.nl=flat&q=*:*&start=0&rows=10&fl=*,score&sort=id asc,name desc',
urldecode($request->getUri()) urldecode($request->getUri())
); );
} }
...@@ -108,7 +108,7 @@ class RequestBuilderTest extends \PHPUnit_Framework_TestCase ...@@ -108,7 +108,7 @@ class RequestBuilderTest extends \PHPUnit_Framework_TestCase
); );
$this->assertEquals( $this->assertEquals(
'select?omitHeader=true&wt=json&q=*:*&start=0&rows=10&fl=*,score&q.op=AND&df=mydefault', 'select?omitHeader=true&wt=json&json.nl=flat&q=*:*&start=0&rows=10&fl=*,score&q.op=AND&df=mydefault',
urldecode($request->getUri()) urldecode($request->getUri())
); );
} }
...@@ -127,7 +127,7 @@ class RequestBuilderTest extends \PHPUnit_Framework_TestCase ...@@ -127,7 +127,7 @@ class RequestBuilderTest extends \PHPUnit_Framework_TestCase
); );
$this->assertEquals( $this->assertEquals(
'select?omitHeader=true&wt=json&q=*:*&start=0&rows=10&fl=*,score&sort=id asc,name desc&fq=published:true&fq={!tag=t1,t2}category:23', 'select?omitHeader=true&wt=json&json.nl=flat&q=*:*&start=0&rows=10&fl=*,score&sort=id asc,name desc&fq=published:true&fq={!tag=t1,t2}category:23',
urldecode($request->getUri()) urldecode($request->getUri())
); );
} }
......
...@@ -72,6 +72,7 @@ class RequestBuilderTest extends \PHPUnit_Framework_TestCase ...@@ -72,6 +72,7 @@ class RequestBuilderTest extends \PHPUnit_Framework_TestCase
'spellcheck.onlyMorePopular' => 'true', 'spellcheck.onlyMorePopular' => 'true',
'spellcheck.collate' => 'true', 'spellcheck.collate' => 'true',
'wt' => 'json', 'wt' => 'json',
'json.nl' => 'flat',
'omitHeader' => 'true', 'omitHeader' => 'true',
), ),
$request->getParams() $request->getParams()
......
...@@ -94,6 +94,7 @@ class RequestBuilderTest extends \PHPUnit_Framework_TestCase ...@@ -94,6 +94,7 @@ class RequestBuilderTest extends \PHPUnit_Framework_TestCase
'terms.upper' => 'x', 'terms.upper' => 'x',
'terms.upper.incl' => 'false', 'terms.upper.incl' => 'false',
'wt' => 'json', 'wt' => 'json',
'json.nl' => 'flat',
'omitHeader' => 'true', 'omitHeader' => 'true',
), ),
$request->getParams() $request->getParams()
......
...@@ -72,7 +72,7 @@ class RequestBuilderTest extends \PHPUnit_Framework_TestCase ...@@ -72,7 +72,7 @@ class RequestBuilderTest extends \PHPUnit_Framework_TestCase
{ {
$request = $this->builder->build($this->query); $request = $this->builder->build($this->query);
$this->assertEquals( $this->assertEquals(
'update?omitHeader=false&wt=json', 'update?omitHeader=false&wt=json&json.nl=flat',
$request->getUri() $request->getUri()
); );
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment