Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Sign in
Toggle navigation
S
Silex
Project overview
Project overview
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Commits
Open sidebar
common
Silex
Commits
780ab698
Commit
780ab698
authored
Sep 07, 2015
by
Fabien Potencier
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fixed some Form deprecations
parent
cb46028d
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
34 additions
and
22 deletions
+34
-22
composer.json
composer.json
+2
-2
src/Silex/Application/FormTrait.php
src/Silex/Application/FormTrait.php
+7
-1
tests/Silex/Tests/Provider/FormServiceProviderTest.php
tests/Silex/Tests/Provider/FormServiceProviderTest.php
+20
-14
tests/Silex/Tests/Provider/ValidatorServiceProviderTest.php
tests/Silex/Tests/Provider/ValidatorServiceProviderTest.php
+5
-5
No files found.
composer.json
View file @
780ab698
{
"minimum-stability"
:
"dev"
,
"name"
:
"silex/silex"
,
"description"
:
"The PHP micro-framework based on the Symfony Components"
,
"keywords"
:
[
"microframework"
],
...
...
@@ -62,5 +61,6 @@
"branch-alias"
:
{
"dev-master"
:
"1.3.x-dev"
}
}
},
"minimum-stability"
:
"dev"
}
src/Silex/Application/FormTrait.php
View file @
780ab698
...
...
@@ -30,6 +30,12 @@ trait FormTrait
*/
public
function
form
(
$data
=
null
,
array
$options
=
array
())
{
return
$this
[
'form.factory'
]
->
createBuilder
(
'form'
,
$data
,
$options
);
$name
=
'Symfony\Component\Form\Extension\Core\Type\FormType'
;
// for BC with Symfony pre 2.7
if
(
!
class_exists
(
'Symfony\Component\Form\Extension\Core\Type\RangeType'
))
{
$name
=
'form'
;
}
return
$this
[
'form.factory'
]
->
createBuilder
(
$name
,
$data
,
$options
);
}
}
tests/Silex/Tests/Provider/FormServiceProviderTest.php
View file @
780ab698
...
...
@@ -47,8 +47,8 @@ class FormServiceProviderTest extends \PHPUnit_Framework_TestCase
return
$extensions
;
}));
$form
=
$app
[
'form.factory'
]
->
createBuilder
(
'form'
,
array
())
->
add
(
'dummy'
,
'dummy'
)
$form
=
$app
[
'form.factory'
]
->
createBuilder
(
class_exists
(
'Symfony\Component\Form\Extension\Core\Type\RangeType'
)
?
'Symfony\Component\Form\Extension\Core\Type\FormType'
:
'form'
,
array
())
->
add
(
'dummy'
,
class_exists
(
'Symfony\Component\Form\Extension\Core\Type\RangeType'
)
?
'Silex\Tests\Provider\DummyFormType'
:
'dummy'
)
->
getForm
();
$this
->
assertInstanceOf
(
'Symfony\Component\Form\Form'
,
$form
);
...
...
@@ -66,8 +66,8 @@ class FormServiceProviderTest extends \PHPUnit_Framework_TestCase
return
$extensions
;
}));
$form
=
$app
[
'form.factory'
]
->
createBuilder
(
'form'
,
array
())
->
add
(
'file'
,
'file'
,
array
(
'image_path'
=>
'webPath'
))
$form
=
$app
[
'form.factory'
]
->
createBuilder
(
class_exists
(
'Symfony\Component\Form\Extension\Core\Type\RangeType'
)
?
'Symfony\Component\Form\Extension\Core\Type\FormType'
:
'form'
,
array
())
->
add
(
'file'
,
class_exists
(
'Symfony\Component\Form\Extension\Core\Type\RangeType'
)
?
'Symfony\Component\Form\Extension\Core\Type\FileType'
:
'file'
,
array
(
'image_path'
=>
'webPath'
))
->
getForm
();
$this
->
assertInstanceOf
(
'Symfony\Component\Form\Form'
,
$form
);
...
...
@@ -107,7 +107,7 @@ class FormServiceProviderTest extends \PHPUnit_Framework_TestCase
return
new
FakeCsrfProvider
();
});
$form
=
$app
[
'form.factory'
]
->
createBuilder
(
'form'
,
array
())
$form
=
$app
[
'form.factory'
]
->
createBuilder
(
class_exists
(
'Symfony\Component\Form\Extension\Core\Type\RangeType'
)
?
'Symfony\Component\Form\Extension\Core\Type\FormType'
:
'form'
,
array
())
->
getForm
();
$form
->
handleRequest
(
$req
=
Request
::
create
(
'/'
,
'POST'
,
array
(
'form'
=>
array
(
...
...
@@ -147,14 +147,20 @@ class FormServiceProviderTest extends \PHPUnit_Framework_TestCase
}
}
class
DummyFormType
extends
AbstractType
{
/**
* @return string The name of this type
*/
public
function
getName
()
if
(
class_exists
(
'Symfony\Component\Form\Extension\Core\Type\RangeType'
))
{
class
DummyFormType
extends
AbstractType
{
}
}
else
{
class
DummyFormType
extends
AbstractType
{
return
'dummy'
;
/**
* @return string The name of this type
*/
public
function
getName
()
{
return
'dummy'
;
}
}
}
...
...
@@ -163,7 +169,7 @@ if (method_exists('Symfony\Component\Form\AbstractType', 'configureOptions')) {
{
public
function
getExtendedType
()
{
return
'file'
;
return
class_exists
(
'Symfony\Component\Form\Extension\Core\Type\RangeType'
)
?
'Symfony\Component\Form\Extension\Core\Type\FileType'
:
'file'
;
}
public
function
configureOptions
(
OptionsResolver
$resolver
)
...
...
@@ -176,7 +182,7 @@ if (method_exists('Symfony\Component\Form\AbstractType', 'configureOptions')) {
{
public
function
getExtendedType
()
{
return
'file'
;
return
class_exists
(
'Symfony\Component\Form\Extension\Core\Type\RangeType'
)
?
'Symfony\Component\Form\Extension\Core\Type\FileType'
:
'file'
;
}
public
function
setDefaultOptions
(
OptionsResolverInterface
$resolver
)
...
...
tests/Silex/Tests/Provider/ValidatorServiceProviderTest.php
View file @
780ab698
...
...
@@ -88,7 +88,7 @@ class ValidatorServiceProviderTest extends \PHPUnit_Framework_TestCase
/**
* @depends testRegister
* @dataProvider
t
estValidatorConstraintProvider
* @dataProvider
getT
estValidatorConstraintProvider
*/
public
function
testValidatorConstraint
(
$email
,
$isValid
,
$nbGlobalError
,
$nbEmailError
,
$app
)
{
...
...
@@ -102,13 +102,13 @@ class ValidatorServiceProviderTest extends \PHPUnit_Framework_TestCase
),
));
$builder
=
$app
[
'form.factory'
]
->
createBuilder
(
'form'
,
array
(),
array
(
$builder
=
$app
[
'form.factory'
]
->
createBuilder
(
class_exists
(
'Symfony\Component\Form\Extension\Core\Type\RangeType'
)
?
'Symfony\Component\Form\Extension\Core\Type\FormType'
:
'form'
,
array
(),
array
(
'constraints'
=>
$constraints
,
'csrf_protection'
=>
false
,
));
$form
=
$builder
->
add
(
'email'
,
'email'
,
array
(
'label'
=>
'Email'
))
->
add
(
'email'
,
class_exists
(
'Symfony\Component\Form\Extension\Core\Type\RangeType'
)
?
'Symfony\Component\Form\Extension\Core\Type\EmailType'
:
'email'
,
array
(
'label'
=>
'Email'
))
->
getForm
()
;
...
...
@@ -140,9 +140,9 @@ class ValidatorServiceProviderTest extends \PHPUnit_Framework_TestCase
}
}
public
function
t
estValidatorConstraintProvider
()
public
function
getT
estValidatorConstraintProvider
()
{
// Email, form is valid
, nb global error, nb email error
// Email, form is valid, nb global error, nb email error
return
array
(
array
(
''
,
false
,
0
,
1
),
array
(
'not an email'
,
false
,
0
,
1
),
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment