bug #1538 Fixed translator.resources definition (skalpa)

This PR was merged into the 2.1.x-dev branch.

Discussion
----------

Fixed translator.resources definition

`translator.resource` is wrongly registered as a protected closure in `TranslationServiceProvider` (it was originally added correctly in dd270386, but changed in 48a3fdc4).

That makes a test fail with Pimple 3.2.1 due to the silexphp/Pimple#190 fix as `translator.resource` can't be extended.

Commits
-------

c5dc42a7 Fixed translator.resources definition

src/Silex/Provider/TranslationServiceProvider.php

@@ -80,9 +80,9 @@ class TranslationServiceProvider implements ServiceProviderInterface, EventListe
             return new MessageSelector();
         };
 
-        $app['translator.resources'] = $app->protect(function ($app) {
+        $app['translator.resources'] = function ($app) {
             return array();
-        });
+        };
 
         $app['translator.domains'] = array();
         $app['locale_fallbacks'] = array('en');

tests/Silex/Tests/Provider/ValidatorServiceProviderTest.php

@@ -82,7 +82,7 @@ class ValidatorServiceProviderTest extends TestCase
      */
     public function testValidatorServiceIsAValidator($app)
     {
-        $this->assertTrue($app['validator'] instanceof ValidatorInterface || $app['validator'] instanceof LegacyValidatorInterface );
+        $this->assertTrue($app['validator'] instanceof ValidatorInterface || $app['validator'] instanceof LegacyValidatorInterface);
     }
 
     /**
@@ -192,4 +192,15 @@ class ValidatorServiceProviderTest extends TestCase
 
         $this->assertEquals('Pas vide', $app['translator']->trans('This value should not be blank.', array(), 'validators', 'fr'));
     }
+
+    public function testTranslatorResourcesIsArray()
+    {
+        $app = new Application();
+        $app['locale'] = 'fr';
+
+        $app->register(new ValidatorServiceProvider());
+        $app->register(new TranslationServiceProvider());
+
+        $this->assertInternalType('array', $app['translator.resources']);
+    }
 }