Commit d89029c6 authored by florianv's avatar florianv

Fixed DoctrineServiceProvider when no logger

parent abb51387
......@@ -86,7 +86,7 @@ class DoctrineServiceProvider implements ServiceProviderInterface
$app['dbs.options.initializer']();
$configs = new Container();
$addLogger = null !== $app['logger'] && class_exists('Symfony\Bridge\Doctrine\Logger\DbalLogger');
$addLogger = isset($app['logger']) && null !== $app['logger'] && class_exists('Symfony\Bridge\Doctrine\Logger\DbalLogger');
foreach ($app['dbs.options'] as $name => $options) {
$configs[$name] = new Configuration();
if ($addLogger) {
......
......@@ -11,6 +11,7 @@
namespace Silex\Tests\Provider;
use Pimple\Container;
use Silex\Application;
use Silex\Provider\DoctrineServiceProvider;
......@@ -85,10 +86,6 @@ class DoctrineServiceProviderTest extends \PHPUnit_Framework_TestCase
$this->markTestSkipped('pdo_sqlite is not available');
}
if (!class_exists('Symfony\Bridge\Doctrine\Logger\DbalLogger')) {
$this->markTestSkipped('Symfony\Bridge\Doctrine\Logger\DbalLogger is not available');
}
$app = new Application();
$this->assertTrue(isset($app['logger']));
$this->assertNull($app['logger']);
......@@ -100,4 +97,20 @@ class DoctrineServiceProviderTest extends \PHPUnit_Framework_TestCase
$this->assertEquals(22, $app['db']->fetchColumn('SELECT 22'));
$this->assertNull($app['db']->getConfiguration()->getSQLLogger());
}
public function testLoggerNotLoaded()
{
if (!in_array('sqlite', \PDO::getAvailableDrivers())) {
$this->markTestSkipped('pdo_sqlite is not available');
}
$app = new Container();
$app->register(new DoctrineServiceProvider(), array(
'dbs.options' => array(
'sqlite1' => array('driver' => 'pdo_sqlite', 'memory' => true),
),
));
$this->assertEquals(22, $app['db']->fetchColumn('SELECT 22'));
$this->assertNull($app['db']->getConfiguration()->getSQLLogger());
}
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment