Commits
-------

5914d4fa TerminableInterface implementation in Application

Discussion
----------

TerminableInterface implementation in Application

It adds finish filters which are triggered after the response has been sent.

---------------------------------------------------------------------------

by igorw at 2012-04-30T22:19:43Z

Cool feature, I can see how this can be useful. Thanks for implementing this!

---------------------------------------------------------------------------

by romainneutron at 2012-04-30T22:24:05Z

Corrections done :)

---------------------------------------------------------------------------

by igorw at 2012-04-30T22:38:36Z

Did not test it, but looks good.

---------------------------------------------------------------------------

by fabpot at 2012-05-01T05:18:06Z

Can you add a note in the CHANGELOG as well?

It adds finish filters which are triggered after the response has been sent.

Commits
-------

53424780 Updated a missed path to the composer autoloading file

Discussion
----------

Updated a missed path to the composer autoloading file

I forgot the phpunit config when updating the path in my previous PR

Commits
-------

ac9dd1f2 added shared services
ccb0452a fixed doc
c57aeab6 fixed typo in doc
06898fb1 corrected translation doc
49f00191 updated tranlation doc with XLIFF and twig infos

Discussion
----------

updated translation doc with XLIFF and Twig infos

Update of PR https://github.com/fabpot/Silex/pull/251

---------------------------------------------------------------------------

by benoitpointet at 2012-03-22T06:48:45Z

fixed typo in doc, please reconsider PR.

---------------------------------------------------------------------------

by igorw at 2012-03-22T19:21:52Z

Apart from the things I mentioned, looks good.

---------------------------------------------------------------------------

by igorw at 2012-03-27T06:30:52Z

👍

---------------------------------------------------------------------------

by benoitpointet at 2012-04-05T18:05:02Z

please reconsider this PR

Commits
-------

7787613e Small grammar tweak. Changed "register" to registered"

Discussion
----------

Small grammar tweak.

Changed "register" to registered" in twig docs

---------------------------------------------------------------------------

by igorw at 2012-04-02T19:15:43Z

👍

Commits
-------

066e7299 Update doc/providers/session.rst

Discussion
----------

Update doc/providers/session.rst

To solve #297 and #299

---------------------------------------------------------------------------

by igorw at 2012-04-06T14:06:05Z

Looks good 👍.

Not sure if we should move session->start to a before filter.

---------------------------------------------------------------------------

by jaywilliams at 2012-04-16T18:55:51Z

I'm glad I found this pull request, because I couldn't figure out why the stated code in the documentation wasn't working.

Commits
-------

560f93a1 Use the composer require-dev key for dev dependencies

Discussion
----------

Use the composer require-dev key for dev dependencies

Commits
-------

49212fcb Updated the compiler for the new Composer file location

Discussion
----------

Updated the compiler for the new Composer file location

This updates the phar for the new location of composer files since composer/composer#603

Old files are created by composer for BC reason but it would not help here as they need the new ones which would not be included in the phar before my change. I haven't included the BC files in the phar as they are not needed (users will not access them directly anyway)

Commits
-------

0a74dcda Removed the Symfony2 tests from the phar archive

Discussion
----------

Removed the Symfony2 tests from the phar archive

Components' tests are now distributed with the code, making the
archive far bigger if we don't exclude them.

---------------------------------------------------------------------------

by igorw at 2012-04-02T06:31:10Z

Was about to do this. 👍

Components' tests are now distributed with the code, making the
archive far bigger if we don't exclude them.

Changed "register" to registered"

Commits
-------

3f22ac3c added autoload_classmap.php to the list of .composer files to include

Discussion
----------

added autoload_classmap.php to the list of .composer files to include

Hi,

I suspect this is my own stupidity since no-one else has reported it, but for me the silex.phar dies when required because it doesn't contain a file that it tries to require: "vendor/.composer/autoload_classmap.php".

I've tried the silex.phar from the project homepage, and also compiled my own from the source code with the same result.  Unpacking either shows indeed that there is no autoload_classmap.php file.

Had a quick look and saw that some other vendor/.composer/*.php files were listed in the Compiler.php class, added in the missing classmap file, and everything seemed to work fine.

As I said, I think I must be missing something, because otherwise silex would be completely broken for just about everybody! using the phar!

---------------------------------------------------------------------------

by chanmix51 at 2012-03-28T12:50:23Z

Hi,

Afaik, the .phar archive does not work with composer as it has not been managed by it. Hence composer does not know anything about phars you could use. I may be wrong but If you use the phar you should use Silex's autoloader or add silex to your dependencies in your `composer.json` instead.

---------------------------------------------------------------------------

by igorw at 2012-03-28T13:54:31Z

@pete-otaqui This should indeed fix the issue 👍

---------------------------------------------------------------------------

by pete-otaqui at 2012-03-28T14:19:44Z

I think you misunderstand me.  I'm not using composer, I just tried the example _from the Silex homepage_:

```php
<?php
require_once __DIR__.'/silex.phar';

$app = new Silex\Application();

$app->get('/hello/{name}', function ($name) use ($app) {
  return 'Hello '.$app->escape($name);
});

$app->run();
```

For me this throws the following error:

```
Warning: require(phar:///var/www/silex/silex.phar/vendor/.composer/autoload_classmap.php): failed to open stream: phar error: "vendor/.composer/autoload_classmap.php" is not a file in phar "/var/www/silex/silex.phar" in phar:///var/www/silex/silex.phar/vendor/.composer/autoload.php on line 17

Fatal error: require(): Failed opening required 'phar:///var/www/silex/silex.phar/vendor/.composer/autoload_classmap.php' (include_path='.:/usr/share/php:/usr/share/pear') in phar:///var/www/silex/silex.phar/vendor/.composer/autoload.php on line 17
```

If you look at the commit I made, you'll see that the Compiler class (which creates the silex.phar) does indeed include some stuff from vendor/.composer/ ... it's just that it doesn't include "autoload_classmap.php".

Possibly this file is supposed to be automatically generated by something inside silex.phar, and for some reason mine isn't writeable, but in that case I ought really to get a different error.

---------------------------------------------------------------------------

by chanmix51 at 2012-03-28T14:23:02Z

Oh sorry, didn't get what the problem was.

---------------------------------------------------------------------------

by igorw at 2012-03-28T18:41:33Z

Fix confirmed 👍 @fabpot please merge asap

---------------------------------------------------------------------------

by simensen at 2012-03-29T15:43:54Z

I was just going to open a PR on this. Good thing I checked first. :)

Commits
-------

0676cd2a Use the application charset as default charset for `$app->escape()` method.

Discussion
----------

Use the application charset as default charset for $app->escape() method

---------------------------------------------------------------------------

by igorw at 2012-03-21T11:47:47Z

👍

I'm curious, are you using something other than UTF-8?

---------------------------------------------------------------------------

by GromNaN at 2012-03-21T12:04:21Z

@igorw The database is encoded in ISO-8859-15. With this patch, I'll only have to change the app charset once the database converted to UTF-8.

Commits
-------

96b0db50 [docs] fixed typo
142143af [docs] fixed typos
32c96a4c [docs] added cookbook recipe on how to disable CSRF Protection using FormExtension

Discussion
----------

[docs] added cookbook recipe on how to disable CSRF Protection using FormExtension

Followed @igorw advice here: https://twitter.com/#!/igorwesome/status/183237649811783682

It also could be awesome to add the FormExtension doc (PR #77) ;)

Commits
-------

c9bbcc0a Use new json function in doc

Discussion
----------

Use new json function in doc

---------------------------------------------------------------------------

by igorw at 2012-03-24T16:53:00Z

Missed that one, thanks. 👍

Commits
-------

a3275875 [json] add changelog entry

Discussion
----------

[json] add changelog entry

Commits
-------

570f475d Improve phar compression

Discussion
----------

Improve phar compression

Just did those changes for composer, with this patch added I only get a 4% size increase from the fully stripped version. Without I had a 33% size increase by adding the "stripComments" method from Silex which kinda sucked. As far as I can tell it doesn't break anything.

Commits
-------

aee65e34 [json] add docs to the usage page
b2566895 [json] adjust json request body recipe
4ce8998a [json] add JSON helper

Discussion
----------

Json

Commits
-------

537b8088 Updated docs to reflect session refactoring
d1bd57d1 Updated to reflect symfony refactoring - needs doc updates

Discussion
----------

Updated Session Provider to reflect symfony refactoring - needs doc updates

I'm not really sure what's required here, but here's what I had to do to get my app working again…

---------------------------------------------------------------------------

by Koin at 2012-03-19T14:12:57Z

omg, thanks davedevelopment.
I'm not the only one to have this problem.

---------------------------------------------------------------------------

by spantaleev at 2012-03-19T20:53:02Z

Good. I just saw this myself and was about to fix it, but you're already ahead.
Can we get the necessary doc updates and have this merged in?

---------------------------------------------------------------------------

by dguyon at 2012-03-20T09:06:32Z

@davedevelopment do you have time to add some docs that reflects your changes ?

---------------------------------------------------------------------------

by igorw at 2012-03-20T09:18:11Z

Looks good to me, please update the docs.

---------------------------------------------------------------------------

by davedevelopment at 2012-03-20T09:26:17Z

Will get the docs updated today
On Mar 20, 2012 9:18 AM, "Igor Wiedler" <
reply@reply.github.com>
wrote:

> Looks good to me, please update the docs.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/fabpot/Silex/pull/284#issuecomment-4591304
>

---------------------------------------------------------------------------

by davedevelopment at 2012-03-20T13:29:09Z

I did a quick test of the above with rst2html and it seem to render ok. The docs at api.symfony.com don't seem to have been updated yet (tried the master branch), so I left out hyperlinks for now.

---------------------------------------------------------------------------

by igorw at 2012-03-20T13:47:20Z

👍

---------------------------------------------------------------------------

by dguyon at 2012-03-20T13:49:38Z

Thanks for this quick patch !