- 24 Aug, 2011 2 commits
-
-
Fabien Potencier authored
-
Fabien Potencier authored
-
- 21 Aug, 2011 1 commit
-
-
Fabien Potencier authored
-
- 20 Aug, 2011 1 commit
-
-
Fabien Potencier authored
-
- 19 Aug, 2011 1 commit
-
-
Fabien Potencier authored
-
- 18 Aug, 2011 6 commits
-
-
Fabien Potencier authored
-
Greg Militello authored
-
Fabien Potencier authored
Commits ------- 5ad81b90 QSA is also unnecessary. as pointed out by @mheleniak 5619a1b6 QSA is also unnecessary. as pointed out by @mheleniak 37f52330 remove unnecessary capturing group c7e44c73 Remove unnecessary capturing group in suggested rewrite rule Discussion ---------- Remove unnecessary capturing group in suggested rewrite rule It's not used, nor needed. --------------------------------------------------------------------------- by mheleniak at 2011/08/15 13:20:15 -0700 Same way `QSA,` could also be stripped in the same line, but this is so small, I think it's not worth the effort :-)) --------------------------------------------------------------------------- by igorw at 2011/08/15 15:12:36 -0700 @AD7six Please update `example.htaccess` as well. @mheleniak I disagree, we do want the query string. --------------------------------------------------------------------------- by mheleniak at 2011/08/15 15:16:14 -0700 @igorw please read the docs about QSA flag: 'qsappend|QSA' (query string append) This flag forces the rewrite engine to append a query string part of the substitution string to the existing string, instead of replacing it. Use this when you want to add more data to the query string via a rewrite rule. http://httpd.apache.org/docs/2.0/mod/mod_rewrite.html This option has nothing to do with passing query string to PHP and in our case can be safely removed. --------------------------------------------------------------------------- by mheleniak at 2011/08/15 15:17:12 -0700 But as I said earlier such small changes usually takes more time to explain than has associated benefit with the change :) --------------------------------------------------------------------------- by AD7six at 2011/08/16 00:48:53 -0700 @mheleniak - interesting perspective. Do you generally recommend doing things in php that aren't necessary to avoid explaining why it's unnecessary? --------------------------------------------------------------------------- by AD7six at 2011/08/16 01:20:36 -0700 @mheleniak is right, the QSA flag is also unnecessary - removing it does not affect the contents of superglobals. I made removing that a seperate commit so that you can cherry-pick if you prefer. --------------------------------------------------------------------------- by lenar at 2011/08/17 10:03:55 -0700 Now that improved rule looks like what I've used for ages.
-
Fabien Potencier authored
-
Fabien Potencier authored
Commits ------- 0d786bdf fixed typo Discussion ---------- fixed typo
-
Julien Brochet authored
-
- 17 Aug, 2011 4 commits
-
-
Fabien Potencier authored
-
Fabien Potencier authored
added Request and Response as arguments to the before and after filters (a bit like error() has access to the Exception)
-
Fabien Potencier authored
changed before and after filters to only run for the master request (as it's mainly used for set up and tear down)
-
Fabien Potencier authored
-
- 16 Aug, 2011 3 commits
-
-
Andy Dawson authored
-
Andy Dawson authored
-
Andy Dawson authored
-
- 15 Aug, 2011 1 commit
-
-
Andy Dawson authored
It's not used, nor needed.
-
- 13 Aug, 2011 1 commit
-
-
Fabien Potencier authored
Commits ------- e9902642 Fixing typos in doc usage.rst Discussion ---------- Fixing some typos in usage.rst Fixing some typos I did in paragraph ioncube loader bug of file usage.rst
-
- 11 Aug, 2011 1 commit
-
-
Laurent Clouet authored
-
- 09 Aug, 2011 7 commits
-
-
Fabien Potencier authored
Commits ------- f7227ba5 updated HttpKernel component Discussion ---------- updated HttpKernel component fatal: reference is not a tree: c1810ca1028e80485d10d695bc10a9574ac03e82 Unable to checkout 'c1810ca1028e80485d10d695bc10a9574ac03e82' in submodule path 'vendor/Symfony/Component/HttpKernel'
-
Julien Brochet authored
-
Fabien Potencier authored
-
Fabien Potencier authored
Commits ------- bb402638 [docs] Symfony => Symfony2 in services doc c51b99bd [docs] adjust usage section of twig 340b6ce2 [docs] add usage section for MonologExtension Discussion ---------- Minor docs additions
-
Fabien Potencier authored
Commits ------- a04c6a01 fix header comments Discussion ---------- fix header comments
-
Fabien Potencier authored
-
Fabien Potencier authored
added a way to get the Application in a Controller without using 'use' (that also allows the usage of class methods as controllers)
-
- 08 Aug, 2011 7 commits
-
-
Igor Wiedler authored
-
Igor Wiedler authored
-
Igor Wiedler authored
-
Igor Wiedler authored
-
Fabien Potencier authored
-
Fabien Potencier authored
It's more consistent with the way we manage other aspects of the controller and it allows to change the method programatically after the creation of the controller. Before: $app->match('/', function () { echo 'foo'; }, 'GET|POST'); After: $app->match('/', function () { echo 'foo'; })->method('GET|POST');
-
Fabien Potencier authored
-
- 04 Aug, 2011 3 commits
-
-
Fabien Potencier authored
Commits ------- 9813ee46 change pimple URL to pimple-project.org (since pimple has its own site now) Discussion ---------- change pimple URL to pimple-project.org (since pimple has its own site no change pimple URL to pimple-project.org (since pimple has its own site now)
-
Fabien Potencier authored
Commits ------- 091dec60 clarify which path to visit to see the first response Discussion ---------- clarify which path to visit to see the first response quite a few people went to `/` and got a 404.
-
Fabien Potencier authored
-
- 01 Aug, 2011 2 commits
-
-
Igor Wiedler authored
-
Igor Wiedler authored
quite a few people went to `/` and got a 404.
-