Commits
-------

e4641d41 made the code more readable
c89133e8 simplified some code

Discussion
----------

Code simplification

I propose to simplify some code. What do you think?

---------------------------------------------------------------------------

by stof at 2012-06-15T12:02:47Z

👍

---------------------------------------------------------------------------

by igorw at 2012-06-15T13:06:12Z

Fine with me. But please add an assignment before `setResponse` to keep the lines a bit shorter.

moved the setting of provider values after the registration to avoid having isset calls everywhere in the provider code

Before, the behavior was not consistent. Some values could be overridden
by passing an array as a second argument to the register() method, but
for most of them it did not work (we would have to wrap all definitions
with an isset()). Now, this is more consistent as you can override
everything that is defined in the provider.

If not, defining the Swiftmailer class_path after registering the
provider does not work.

moved the checks for *.class_path parameters to the boot method as people might have defined the parameter after the register method is called

Commits
-------

d53119eb added a route after middleware
794b3c28 renamed middleware() to before()

Discussion
----------

Implements route after middleware (closes #336)

This PR renames the `middleware` method to `before` and adds a new `after` route middleware.

These changes make Silex more consistent from a user point of view:

 * he can do something before the route callback on an application, a route collection, or just a route (by calling the `before` method on these objects);

 * he can do something after the route callback by calling the `after` method on an application, a route collection, or just a route.

---------------------------------------------------------------------------

by fabpot at 2012-06-13T18:20:37Z

I thought about using the `middleware` method for both before and after by passing the callback as an argument. But this has several drawback:

 * we loose the symmetry with the application before/after calls;
 * the developer must remember to manually call the callback (and symfony1 proves that many devs actually forgets about that);
 * this would act as a filter chain where the order of execution is not always clear when you have many filters.

Commits
-------

1e5d0f41 Fixed the composer constraints to have an upper bound

Discussion
----------

Fixed the composer constraints to have an upper bound

added a fat archive which contains many more Symfony component and third-party libraries (closes #365)

Commits
-------

256859b6 [docs] Documentation for FormExtension

Discussion
----------

Form docs

[docs] FormExtension docs

---------------------------------------------------------------------------

by alOneh at 2011-05-11T17:58:13Z

I think the form doc is now clean, isnt'it ?

---------------------------------------------------------------------------

by brikou at 2011-06-27T19:19:46Z

👍

---------------------------------------------------------------------------

by rkmax at 2011-07-29T19:30:28Z

thanks, i'm looking for this

---------------------------------------------------------------------------

by alOneh at 2011-07-29T19:32:29Z

@fabpot can you merge this if you are agree with that pull ?

---------------------------------------------------------------------------

by rkmax at 2011-07-30T14:27:09Z

can you explain what /vendor/symfony/src need exactly

---------------------------------------------------------------------------

by alOneh at 2011-07-31T13:27:39Z

/vendor/symfony/src is use to load the Symfony Form component, the [Symfony Bridge](http://api.symfony.com/2.0/Symfony/Bridge/Twig/Extension.html) who provide extensions for Form and Translation in Twig

---------------------------------------------------------------------------

by rkmax at 2011-08-01T09:51:30Z

thanks @alOneh

---------------------------------------------------------------------------

by igorw at 2011-09-18T15:06:44Z

@fabpot is there anything missing? Would be nice to get this merged finally.

---------------------------------------------------------------------------

by alOneh at 2011-09-20T08:42:49Z

@fabpot are you agree with that PR ?

---------------------------------------------------------------------------

by alOneh at 2011-09-22T10:39:23Z

I just updated the form provider documenation

---------------------------------------------------------------------------

by igorw at 2011-10-07T14:41:17Z

Keep an eye on #182.

---------------------------------------------------------------------------

by alOneh at 2011-10-07T15:00:28Z

Seems good to me. I will update the doc when it will be merged.

---------------------------------------------------------------------------

by alOneh at 2011-10-09T12:57:51Z

@fabpot : I updated my proposal PR for the FormServiceProvider. Can you check if there is anything missing ? /cc igorw

---------------------------------------------------------------------------

by igorw at 2011-10-09T13:05:49Z

Looks good to me.

Might be interesting to add another section about validation using the `validation_constraint` form option, see also http://knplabs.com/en/blog-csi/symfony-validators-standalone

---------------------------------------------------------------------------

by alOneh at 2011-10-09T14:02:38Z

I updated the example with the validation_constraint, I think now its good.

---------------------------------------------------------------------------

by alOneh at 2011-10-10T19:51:56Z

poke @fabpot

---------------------------------------------------------------------------

by igorw at 2011-10-10T19:55:05Z

Looks good to me.

---------------------------------------------------------------------------

by igorw at 2011-10-16T23:53:48Z

Hm, maybe validation_constraint should be a separate example. Also we should not use the UrlGenerator.

IMO it needs to be clear that those things are optional.

---------------------------------------------------------------------------

by alOneh at 2011-10-18T09:01:48Z

@igorw, I use the UrlGenerator because I can't get a fully working example without it.

---------------------------------------------------------------------------

by netzhuffle at 2011-11-28T17:15:12Z

@alOneh You could try $request->getUriForPath() instead of the UrlGenerator.

---------------------------------------------------------------------------

by alOneh at 2012-01-16T14:47:20Z

is this PR is ready for merge after the latest change ?

---------------------------------------------------------------------------

by igorw at 2012-01-16T15:02:12Z

It introduces extensions.rst which was renamed to providers.rst. You need to merge upstream master into your branch and then make sure everything is correct.

---------------------------------------------------------------------------

by alOneh at 2012-01-16T15:52:00Z

My mistake. I fix this.

---------------------------------------------------------------------------

by alOneh at 2012-02-12T23:00:03Z

poke @igorw @fabpot

---------------------------------------------------------------------------

by igorw at 2012-02-12T23:04:01Z

This (still) looks good to me.

Minor thing: API docs links should probably be changed to 2.1 now. Not sure if others are also affected.

---------------------------------------------------------------------------

by alOneh at 2012-02-12T23:08:06Z

Others are not yet affected. Maybe in a single PR for all API docs links

---------------------------------------------------------------------------

by alOneh at 2012-02-22T11:03:39Z

poke @igorw , @fabpot

---------------------------------------------------------------------------

by alOneh at 2012-03-02T14:01:17Z

@igorw I updated the docs references to 2.1, ready for merge now ? /cc @fabpot

---------------------------------------------------------------------------

by igorw at 2012-03-02T15:30:52Z

👍

---------------------------------------------------------------------------

by fabpot at 2012-06-13T18:59:12Z

Can you squash your commits. I will then merge and made some changes due to some recent updates to Silex. Thanks.