Skip to content

S
Silex
Switch branch/tag
  1. 01 Oct, 2013 1 commit
  3. 19 Jun, 2013 1 commit
  5. 25 May, 2013 4 commits
    • Fabien Potencier's avatar
      tweaked changelog · c2148890
      Fabien Potencier authored
      c2148890
    • Fabien Potencier's avatar
      merged branch igorw/lazy-dispatcher (PR #705) · d61569b6
      Fabien Potencier authored 
      This PR was submitted for the 1.0 branch but it was merged into the master branch instead (closes #705).

Discussion
----------

Make dispatcher lazy, do not trigger its creation on middleware definition

The dispatcher has quite a few dependencies due to all of the subscribers
that are added to it. One of these is the logger, several other services
are affected as well though.

The listener shortcut methods like on(), before(), after(), error() all
force creation of the dispatcher and thus all of its dependencies. This
makes it impossible to have lazy configuration of those services.

The specific issue that triggered this was lazy configuration of the logger,
which simply does not work once you have before() or after().

By using extend(), all of those shortcut calls can delay the creation of
the dispatcher and thus solve the issue. It will add a slight overhead, but
it should be relatively small, since the results of creating a service are
memoized through share().

Commits
-------

efa0383 Add changelog entry for lazy dispatcher proxies
59b56b0 Make dispatcher lazy, do not trigger its creation on middleware definition
      d61569b6
    • Igor Wiedler's avatar
      Add changelog entry for lazy dispatcher proxies · 41fc16a6
      Igor Wiedler authored
      41fc16a6
    • Igor Wiedler's avatar
      Make dispatcher lazy, do not trigger its creation on middleware definition · 237ed42d
      Igor Wiedler authored 
      The dispatcher has quite a few dependencies due to all of the subscribers
that are added to it. One of these is the logger, several other services
are affected as well though.

The listener shortcut methods like on(), before(), after(), error() all
force creation of the dispatcher and thus all of its dependencies. This
makes it impossible to have lazy configuration of those services.

The specific issue that triggered this was lazy configuration of the logger,
which simply does not work once you have before() or after().

By using extend(), all of those shortcut calls can delay the creation of
the dispatcher and thus solve the issue. It will add a slight overhead, but
it should be relatively small, since the results of creating a service are
memoized through share().
      237ed42d
  7. 04 May, 2013 1 commit
    • Fabien Potencier's avatar
      merged branch igorw/1.1-deps (PR #695) · e9e1b209
      Fabien Potencier authored 
      This PR was merged into the master branch.

Discussion
----------

[1.1] Drop support for symfony/* <2.3

I've left the ranges in, because it's likely that we will extend them in the future.

Commits
-------

54be4f51 [1.1] Remove symfony <2.3 hacks
2b45f600 [1.1] Add minimum-stability of dev
8f8ba416 [1.1] Update all symfony version references in the docs to 2.3
7a14b209 [1.1] Update symfony versions in fat composer.json
e9478ddd Drop support for symfony/* <2.3
      e9e1b209
  9. 03 May, 2013 16 commits
  11. 02 May, 2013 1 commit
  13. 01 May, 2013 2 commits
  15. 30 Apr, 2013 2 commits
  17. 27 Apr, 2013 1 commit
  19. 26 Apr, 2013 4 commits
  21. 24 Apr, 2013 1 commit
    • Fabien Potencier's avatar
      merged branch alexkappa/master (PR #628) · 8bf675f5
      Fabien Potencier authored 
      This PR was merged into the master branch.

Discussion
----------

Ported ConstraintValidatorFactory.php to Silex

Included a modified version of `ConstraintValidatorFactory` to Silex for use with custom constraints.

Since Silex comes with `ValidatorServiceProvider` built in, I guess it makes sense to include this, in case users might want dependencies with their custom validators.

Usage would be:

```php
// Custom.php
public function validatedBy()
{
    return 'my.validator.custom';
}

// index.php
$app['validator.custom'] = $app->share(function ($app) {
    return new CustomValidator();
});
$app->register(new ValidatorServiceProvider(), array(
    'validator.validator_service_ids' => array(
        'my.validator.custom' => 'validator.custom'
    )
));
```

Commits
-------

c4466a18 Changed constructor type hint to Pimple
fd72c6ab Incorporated changes suggested by @Igorow. Separating $this->validators (instances) and $this->serviceNames.
fa15389b Separating validator service names and instances
0c3234d2 Minor refactoring
83266af9 Changed mapping of 'validator.validator_service_ids' to use ternary operator
278c5e01 Backward compatibility for UserPasswordValidator
40734452 Changed deprecated namespaces
4d8956f3 Added custom constraint and validator to properly test the ConstraintValidatorFactory.
b45b4fb2 SecurityServiceProvider now registers a UserPasswordValidator if ValidatorServiceProvider is registered.
70c1e365 Registering a ValidatorServiceProvider can take a validator.validator_service_ids parameter which is now an associative array of aliases as keys and service names as values so that ConstraintValidatorFactory can lazy load the validators.
77af56be Removed Symfony\Component\Validator\ConstraintValidatorFactory altogether from ValidatorServiceProvider. Custom validators are now lazy loaded. removed obsolete test.
423138aa - Type hint in Silex\ConstraintValidatorFactory constructor for container - Modifed Silex\Provider\ValidatorServiceProvider to accept an optional   'validator.validator_service_ids' parameter wich allows users to register   custom validators. - Added test to verify that if users registered ValidatorServiceProvider   using optional 'validator.validator_service_ids' parameter then the new   Silex\ConstraintValidatorFactory will be used instead of the one provided   in  Symfony.
eaf0af2a Ported ConstraintValidatorFactory.php to Silex/Pimple
      8bf675f5
  23. 23 Apr, 2013 2 commits
  25. 22 Apr, 2013 1 commit
  27. 12 Apr, 2013 1 commit
  29. 11 Apr, 2013 2 commits