1. 18 Sep, 2011 3 commits
  2. 26 Aug, 2011 2 commits
  3. 25 Aug, 2011 2 commits
  4. 24 Aug, 2011 7 commits
  5. 21 Aug, 2011 1 commit
  6. 20 Aug, 2011 1 commit
  7. 19 Aug, 2011 1 commit
  8. 18 Aug, 2011 6 commits
    • Fabien Potencier's avatar
      refactored the Doctrine extension · 15b725ce
      Fabien Potencier authored
      15b725ce
    • Greg Militello's avatar
    • Fabien Potencier's avatar
      merged branch AD7six/patch-1 (PR #150) · bda57d54
      Fabien Potencier authored
      Commits
      -------
      
      5ad81b90 QSA is also unnecessary. as pointed out by @mheleniak
      5619a1b6 QSA is also unnecessary. as pointed out by @mheleniak
      37f52330 remove unnecessary capturing group
      c7e44c73 Remove unnecessary capturing group in suggested rewrite rule
      
      Discussion
      ----------
      
      Remove unnecessary capturing group in suggested rewrite rule
      
      It's not used, nor needed.
      
      ---------------------------------------------------------------------------
      
      by mheleniak at 2011/08/15 13:20:15 -0700
      
      Same way `QSA,` could also be stripped in the same line, but this is so small, I think it's not worth the effort :-))
      
      ---------------------------------------------------------------------------
      
      by igorw at 2011/08/15 15:12:36 -0700
      
      @AD7six Please update `example.htaccess` as well.
      
      @mheleniak I disagree, we do want the query string.
      
      ---------------------------------------------------------------------------
      
      by mheleniak at 2011/08/15 15:16:14 -0700
      
      @igorw please read the docs about QSA flag:
      
           'qsappend|QSA' (query string append)
           This flag forces the rewrite engine to append a query string part of the substitution
           string to the existing string, instead of replacing it. Use this when you want to add
           more data to the query string via a rewrite rule.
      
      http://httpd.apache.org/docs/2.0/mod/mod_rewrite.html
      
      This option has nothing to do with passing query string to PHP and in our case can be safely removed.
      
      ---------------------------------------------------------------------------
      
      by mheleniak at 2011/08/15 15:17:12 -0700
      
      But as I said earlier such small changes usually takes more time to explain than has associated benefit with the change :)
      
      ---------------------------------------------------------------------------
      
      by AD7six at 2011/08/16 00:48:53 -0700
      
      @mheleniak - interesting perspective. Do you generally recommend doing things in php that aren't necessary to avoid explaining why it's unnecessary?
      
      ---------------------------------------------------------------------------
      
      by AD7six at 2011/08/16 01:20:36 -0700
      
      @mheleniak is right, the QSA flag is also unnecessary - removing it does not affect the contents of superglobals.
      
      I made removing that a seperate commit so that you can cherry-pick if you prefer.
      
      ---------------------------------------------------------------------------
      
      by lenar at 2011/08/17 10:03:55 -0700
      
      Now that improved rule looks like what I've used for ages.
      bda57d54
    • Fabien Potencier's avatar
      fixed markup in the doc · f263e64a
      Fabien Potencier authored
      f263e64a
    • Fabien Potencier's avatar
      merged branch aerialls/patch-1 (PR #152) · 9d8b3f5f
      Fabien Potencier authored
      Commits
      -------
      
      0d786bdf fixed typo
      
      Discussion
      ----------
      
      fixed typo
      9d8b3f5f
    • Julien Brochet's avatar
      fixed typo · 0d786bdf
      Julien Brochet authored
      0d786bdf
  9. 17 Aug, 2011 4 commits
  10. 16 Aug, 2011 3 commits
  11. 15 Aug, 2011 1 commit
  12. 13 Aug, 2011 1 commit
  13. 11 Aug, 2011 1 commit
  14. 09 Aug, 2011 7 commits