This PR was merged into the 2.1.x-dev branch.

Discussion
----------

Error using EsiFragment with provider and twig functions

Trying to use twig functions "controller" and "render_esi" like [Symfony esi reference](http://symfony.com/doc/current/http_cache/esi.html) , i've noticed the following error:
An exception has been thrown during the rendering of a template ("You must use a URI when using the ESI rendering strategy or set a URL signer.").

It's the lack of a UriSigner on the constructor.

Commits
-------

c6bbc48b Update HttpFragmentServiceProvider.php

This PR was merged into the 2.1.x-dev branch.

Discussion
----------

add json manifest version strategy support

Commits
-------

65382f4c add json manifest version strategy support

This PR was merged into the 2.1.x-dev branch.

Discussion
----------

RedirectableUrlMatcher needs to return a proper array with the _route parameter

Symfony's HttpUtils's checkRequestPath() expects RedirectableUrlMatcher to return an array with '_route'. This throws a notice `Undefined index: _route`:

```
        $coll = new RouteCollection();
        $coll->add('foo', new Route('/foo', array(), array(), array(), '', array('https')));
        $matcher = new RedirectableUrlMatcher($coll, new RequestContext());
        $httpUtils = new HttpUtils(null, $matcher);
        $request = Request::create('http://example.com/foo');
        $httpUtils->checkRequestPath($request, 'foo');
```

It's an issue with my app although I haven't yet taken the time to make a simplified app to show the issue besides the above.

Commits
-------

e6d41b8d RedirectableUrlMatcher needs to return a proper array with the _route parameter

This PR was squashed before being merged into the 2.1.x-dev branch (closes #1529).

Discussion
----------

Added test of FormTrait::namedForm()

I did not see the test of FormTrait::namedForm(), so I created it.

Commits
-------

32640626 Added test of FormTrait::namedForm()

This PR was squashed before being merged into the 2.1.x-dev branch (closes #1523).

Discussion
----------

Test all the 3.x branches in Travis

I enhanced the Travis config to ensure the tests are run against all the available 3.x branches.

Before the changes:
- The tests were run against `2.8` when `$SYMFONY_DEPS_VERSION` was unset
- There were additional envs for `3.0`, `3.1` and `3.2`

After the changes:
- When `$SYMFONY_DEPS_VERSION` is unset, `composer.json` is left unchanged and the tests are run against the most recent `3.x-dev` branch (what you'd get by running phpunit locally)
- There are envs to test all the symfony branches from `2.8` to `3.3`

I also fixed the cache (there were two `cache/directories` sections) and made the syntax more consistent overall.

This changes the behaviors of the build: before, `Twig 2.x` was tested with `2.8`. Now, it is tested alongside the most recent `3.x`. I believe it makes more sense like this, however if the old behavior was on purpose (i.e because `2.8` is still the most recent _lts_), I can still switch back and add envs for `3.3` and `3.4` instead.

Regarding the changes to the tests:

I originally removed `symfony/web-link` from the list of dependencies when testing against `< 3.3`, as something like this will be necessary later when adding `symfony/cache` support which conflicts with `symfony/var-dumper < 3.3`.

However, as this was not necessary and actually prevented us to check that the WebLink integration didn't break when the component was available but associated with an old version of the `twig-bridge`, I ultimately rolled back the change. Yet, I kept the checks in the tests as they are cleaner this way IMO (anyway they're in a separate commit so I could just remove them too if you want).

Commits
-------

5557944d Test all the 3.x branches in Travis

This PR was merged into the 2.1.x-dev branch.

Discussion
----------

Docs: Update interface reference for csrf.token_manager

The csrf.token_manager is an implementation of CsrfTokenManagerInterface
Fix the label and link to the reference
Update Usage section to include creation of a new token

Commits
-------

0a0c2d9e Update interface reference for csrf.token_manager

This PR was merged into the 2.1.x-dev branch.

Discussion
----------

Remove outdated example code from documentation

The `user` method hasn't been part of the security
trait since 7052d972 over 2 years ago.

Commits
-------

7367244f Remove outdated example code from documentation

The `user` method hasn't been part of the security
trait since 7052d972 over 2 years ago.

The csrf.token_manager is an implementation of CsrfTokenManagerInterface
Fix the label and link to the reference
Update Usage section to include creation of a new token

This PR was squashed before being merged into the 2.1.x-dev branch (closes #1528).

Discussion
----------

Fix exception hander test

In symfony 3.3.0, the markup of the error wording has been changed.

https://github.com/symfony/symfony/pull/22838

3.2.x
`<h1>$title</h1>`

3.3.0
`<h1 class="break-long-words exception-message">$title</h1>`

Therefore, in the symfony 3.3.0 environment, ExceptionHandlerTest fails.

```
1) Silex \ Tests \ ExceptionHandlerTest :: testExceptionHandlerExceptionNoDebug
Failed asserting that '<! DOCTYPE html>

...

Contains "<h1> Whoops, looks like something went wrong. </h1>".
```

https://github.com/symfony/symfony/pull/22838/files#diff-5a9ac37e71d14aa261fe6f68848a6277L42

I deleted `<h1>` by referring to it.

Commits
-------

69e2771b Fix exception hander test

Trying to use twig functions "controller" and "render_esi" like [Symfony esi reference](http://symfony.com/doc/current/http_cache/esi.html) , i've noticed the following error:
An exception has been thrown during the rendering of a template ("You must use a URI when using the ESI rendering strategy or set a URL signer.").

It's the lack of a UriSigner on the constructor.

This PR was squashed before being merged into the 2.1.x-dev branch (closes #1521).

Discussion
----------

Update web_servers.rst

Reformat code listing

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/silexphp/silex/1521)
<!-- Reviewable:end -->

Commits
-------

6b9319ac Update web_servers.rst

This PR was merged into the 2.1.x-dev branch.

Discussion
----------

Clarify documentations around protected closures.

The docs state that "protected closures do not get access to the container", but this is somewhat misleading (it confused me for a quite some time). It's true that protected closures are not passed the container as a function argument, but they can access the container via `use ($app)`.

Commits
-------

45d9113d Clarify documentations around protected closures.

The docs state that "protected closures do not get access to the container", but this is somewhat misleading (it confused me for a quite some time). It's true that protected closures are not passed the container as a function argument, but they can access the container via `use ($app)`.

This PR was squashed before being merged into the 2.1.x-dev branch (closes #1514).

Discussion
----------

Fixed WebTestCase compatibility with PHPUnit 6+

Makes `WebTestCase` inherit from `PHPUnit\Framework\TestCase` instead of `PHPUnit_Framework_TestCase`.

Strictly speaking it's a BC break, but as the namespaced class is now available in PHPUnit 4.8.35, 5.4+ and 6.x it's probable safe.

Commits
-------

619018a7 Fixed WebTestCase compatibility with PHPUnit 6+

This PR was squashed before being merged into the 2.1.x-dev branch (closes #1515).

Discussion
----------

Use PHPUnit\Framework\TestCase in Silex tests

I changed all the tests so they use the namespaced class instead of `PHPUnit_Framework_TestCase`.

That doesn't really bring anything, but will be one less thing to change when Silex switches to PHP7/PHPUnit 6.

Commits
-------

f8731dad Use PHPUnit\Framework\TestCase in Silex tests

This PR was merged into the 2.1.x-dev branch.

Discussion
----------

Update session.rst to explain handlers

Expand the documentation to explain how to use different session providers.

Commits
-------

a925171a Update session.rst to explain handlers

This PR was merged into the 2.1.x-dev branch.

Discussion
----------

Update guard_authentication.rst

isPasswordValid() needs hashed password, not plaintext.

Commits
-------

1a86c8ac Update guard_authentication.rst

This PR was merged into the 2.1.x-dev branch.

Discussion
----------

Update web_servers.rst

Just another option for Apache that works

Commits
-------

d639b447 Update web_servers.rst

This PR was squashed before being merged into the 2.1.x-dev branch (closes #1503).

Discussion
----------

Added more options to security.firewalls

Added "methods" and "hosts" options to security.firewalls

Commits
-------

262bc73c Added more options to security.firewalls

This PR was merged into the 2.1.x-dev branch.

Discussion
----------

Added WebLink component integration

I made the necessary changes to support the new WebLink component:

- `HttpKernelServiceProvider` registers the `AddLinkHeaderListener` if the component is available
- `TwigServiceProvider` adds the `WebLinkExtension` if the component and the Twig bridge are available
- Both changes are tested
- The documentation has been amended (the link to the Symfony website doesn't work as 3.3 hasn't been released yet but I believe it's the good URL)

Commits
-------

37bd5aed Added WebLink component integration

This PR was merged into the 2.1.x-dev branch.

Discussion
----------

Added parameters to configure the Twig core extension behavior

This adds the following parameters to configure `Twig_Extension_Core`:

- `twig.date.format` (default `date` format)
- `twig.date.interval_format` (default `date` format for intervals)
- `twig.date.timezone` (default timezone)
- `twig.number_format.decimals` (default number of decimals for `number_format`)
- `twig.number_format.decimal_point` (default decimals separator for `number_format`)
- `twig.number_format.thousands_separator` (default thousands separator for `number_format`)

Commits
-------

99a4fb35 Added parameters to configure the Twig core extension behavior

This PR was merged into the 2.1.x-dev branch.

Discussion
----------

Fix deprecation notice with symfony/twig-bridge 3.2+ in TwigServiceProvider

Fixes the deprecation triggered when instantiating `FormExtension` twig-bridge with 3.2+.

I check for the existence of `Symfony\Bridge\Twig\Extension\HttpKernelRuntime` to determine if we're using 3.2 as it was added in 3.2.0-beta1.

Commits
-------

6615118d Fix deprecation notice with symfony/twig-bridge 3.2+ in TwigServiceProvider