1. 15 Jun, 2017 4 commits
    • Fabien Potencier's avatar
      minor #1523 Test all the 3.x branches in Travis (skalpa) · 8e187c12
      Fabien Potencier authored
      This PR was squashed before being merged into the 2.1.x-dev branch (closes #1523).
      
      Discussion
      ----------
      
      Test all the 3.x branches in Travis
      
      I enhanced the Travis config to ensure the tests are run against all the available 3.x branches.
      
      Before the changes:
      - The tests were run against `2.8` when `$SYMFONY_DEPS_VERSION` was unset
      - There were additional envs for `3.0`, `3.1` and `3.2`
      
      After the changes:
      - When `$SYMFONY_DEPS_VERSION` is unset, `composer.json` is left unchanged and the tests are run against the most recent `3.x-dev` branch (what you'd get by running phpunit locally)
      - There are envs to test all the symfony branches from `2.8` to `3.3`
      
      I also fixed the cache (there were two `cache/directories` sections) and made the syntax more consistent overall.
      
      This changes the behaviors of the build: before, `Twig 2.x` was tested with `2.8`. Now, it is tested alongside the most recent `3.x`. I believe it makes more sense like this, however if the old behavior was on purpose (i.e because `2.8` is still the most recent _lts_), I can still switch back and add envs for `3.3` and `3.4` instead.
      
      Regarding the changes to the tests:
      
      I originally removed `symfony/web-link` from the list of dependencies when testing against `< 3.3`, as something like this will be necessary later when adding `symfony/cache` support which conflicts with `symfony/var-dumper < 3.3`.
      
      However, as this was not necessary and actually prevented us to check that the WebLink integration didn't break when the component was available but associated with an old version of the `twig-bridge`, I ultimately rolled back the change. Yet, I kept the checks in the tests as they are cleaner this way IMO (anyway they're in a separate commit so I could just remove them too if you want).
      
      Commits
      -------
      
      5557944d Test all the 3.x branches in Travis
      8e187c12
    • Pascal Luna's avatar
      Test all the 3.x branches in Travis · 5557944d
      Pascal Luna authored
      5557944d
    • Fabien Potencier's avatar
      fixed CS · 77e86f11
      Fabien Potencier authored
      77e86f11
    • Fabien Potencier's avatar
      minor #1532 Docs: Update interface reference for csrf.token_manager (thisisandrew) · 682e1a56
      Fabien Potencier authored
      This PR was merged into the 2.1.x-dev branch.
      
      Discussion
      ----------
      
      Docs: Update interface reference for csrf.token_manager
      
      The csrf.token_manager is an implementation of CsrfTokenManagerInterface
      Fix the label and link to the reference
      Update Usage section to include creation of a new token
      
      Commits
      -------
      
      0a0c2d9e Update interface reference for csrf.token_manager
      682e1a56
  2. 12 Jun, 2017 2 commits
  3. 10 Jun, 2017 1 commit
  4. 02 Jun, 2017 2 commits
  5. 19 May, 2017 2 commits
  6. 14 May, 2017 3 commits
    • Fabien Potencier's avatar
      tweaked an example · 694fe555
      Fabien Potencier authored
      694fe555
    • Fabien Potencier's avatar
      minor #1517 Clarify documentations around protected closures. (jordanlev) · c7a108a1
      Fabien Potencier authored
      This PR was merged into the 2.1.x-dev branch.
      
      Discussion
      ----------
      
      Clarify documentations around protected closures.
      
      The docs state that "protected closures do not get access to the container", but this is somewhat misleading (it confused me for a quite some time). It's true that protected closures are not passed the container as a function argument, but they can access the container via `use ($app)`.
      
      Commits
      -------
      
      45d9113d Clarify documentations around protected closures.
      c7a108a1
    • Jordan Lev's avatar
      Clarify documentations around protected closures. · 45d9113d
      Jordan Lev authored
      The docs state that "protected closures do not get access to the container", but this is somewhat misleading (it confused me for a quite some time). It's true that protected closures are not passed the container as a function argument, but they can access the container via `use ($app)`.
      45d9113d
  7. 09 May, 2017 4 commits
  8. 03 May, 2017 14 commits
  9. 02 May, 2017 2 commits
    • Fabien Potencier's avatar
      minor #1510 Fix AssetServiceProviderTest::testGenerateAssetUrl (skalpa) · 1b2f0394
      Fabien Potencier authored
      This PR was merged into the 2.1.x-dev branch.
      
      Discussion
      ----------
      
      Fix AssetServiceProviderTest::testGenerateAssetUrl
      
      The test broke when symfony/symfony#22528 got merged.
      
      I added one check without the starting slash (the returned path should be relative to `base_path`) and modified the expectation of the check with the starting slash (the returned path should not be relative).
      
      ```
      There was 1 failure:
      
      1) Silex\Tests\Provider\AssetServiceProviderTest::testGenerateAssetUrl
      Failed asserting that two strings are equal.
      --- Expected
      +++ Actual
      @@ @@
      -'/whatever-makes-sense/foo.css?css2'
      +'/foo.css?css2'
      ```
      
      Commits
      -------
      
      ce8e41b5 Fix AssetServiceProviderTest::testGenerateAssetUrl
      1b2f0394
    • Pascal Luna's avatar
      ce8e41b5
  10. 30 Apr, 2017 3 commits
  11. 23 Apr, 2017 1 commit
  12. 14 Mar, 2017 2 commits