- 01 Nov, 2013 1 commit
-
-
Fabien Potencier authored
This PR was merged into the master branch. Discussion ---------- Converters This PR reverts #769 (which tried to fix #768) as this is a breaks BC for the most usual use case of converters (#806). The decision has been taken (#814) that a converter always run, independently of the available request attribute names or controller argument names. Because of the above, running the converters as a controller event is not needed anymore, and moving the converters earlier in the process gives more power to the developer (#825 and #826). Commits ------- a0644877 Convert request attributes in the KernelEvents::REQUEST event instead of KernelEvents::CONTROLLER event (closes #825) 3b207399 added a note about global converters being applied to all controllers 76776926 Revert "merged branch igorw/convert-only-existing-attribute (PR #769)"
-
- 31 Oct, 2013 6 commits
-
-
Fabien Potencier authored
-
Fabien Potencier authored
This PR was merged into the master branch. Discussion ---------- fixed the form example to not use deprecated methods see #822 Commits ------- fa45d9a1 fixed the form example to not use deprecated methods
-
Romain Neutron authored
Convert request attributes in the KernelEvents::REQUEST event instead of KernelEvents::CONTROLLER event (closes #825)
-
Fabien Potencier authored
-
Fabien Potencier authored
This reverts commit e7d4a2fd, reversing changes made to d6fe48ea. Conflicts: doc/changelog.rst src/Silex/EventListener/ConverterListener.php
-
Fabien Potencier authored
-
- 30 Oct, 2013 6 commits
-
-
Fabien Potencier authored
This PR was squashed before being merged into the master branch (closes #823). Discussion ---------- [RFR] various clean ups - [x] fixing typos and typehinting checkroute method - [x] remove unused use statements - [x] make consistent test use statement without line break separation Commits ------- 727f5b7a [RFR] various clean ups
-
Luis Cordova authored
-
Fabien Potencier authored
This PR was merged into the master branch. Discussion ---------- Default HttpCache debug option to that of the main container Commits ------- 9cd048c7 Default HttpCache debug option to that of
-
Dave Marshall authored
-
Fabien Potencier authored
* 1.1: Event helpers add listeners directly after boot fix docblock Update intro.rst - Included links to Symfony2, Pimple and Sinatra typo fixed in doc/providers.rst
-
Fabien Potencier authored
* 1.0: fix docblock Update intro.rst - Included links to Symfony2, Pimple and Sinatra typo fixed in doc/providers.rst
-
- 29 Oct, 2013 1 commit
-
-
Fabien Potencier authored
-
- 28 Oct, 2013 2 commits
-
-
Fabien Potencier authored
This PR was merged into the master branch. Discussion ---------- Fixed typo in "Controllers in classes" paragraph Commits ------- 0983ea1f Fixed typo in "Controllers in classes" paragraph
-
sensorario authored
-
- 26 Oct, 2013 4 commits
-
-
Fabien Potencier authored
-
Fabien Potencier authored
This PR was merged into the master branch. Discussion ---------- fixed order of route registration for mounted controllers simpler alternative for #736 in order to fix #716 Commits ------- 4e6031e2 fixed order of route registration for mounted controllers
-
Fabien Potencier authored
This PR was submitted for the master branch but it was merged into the 1.1 branch instead (closes #815). Discussion ---------- Event helpers add listeners directly after boot Fixes #748 Commits ------- f67cd45 Event helpers add listeners directly after boot
-
Dave Marshall authored
Fixes #748
-
- 19 Oct, 2013 1 commit
-
-
Fabien Potencier authored
-
- 16 Oct, 2013 4 commits
-
-
Fabien Potencier authored
This PR was merged into the master branch. Discussion ---------- Fix changelog entry Commits ------- 885870e6 Fix changelog entry
-
Romain Neutron authored
-
Fabien Potencier authored
This PR was squashed before being merged into the master branch (closes #800). Discussion ---------- Converters as service This PR decouples the callback resolution service from `ServiceControllerResolver` in `CallbackResolver` so it can be used to resolve converter callback declared a service callbacks : ```php $app->get('/user/{user}', function (User $user) { // ... })->convert('user', 'service:method'); ``` Commits ------- 0cdef8e5 Converters as service
-
Romain Neutron authored
-
- 14 Oct, 2013 1 commit
-
-
Fabien Potencier authored
This PR was merged into the master branch. Discussion ---------- changed the default controller to be unique for the whole app Commits ------- 9c68da8d changed the default controller to be unique for the whole app
-
- 13 Oct, 2013 1 commit
-
-
Fabien Potencier authored
-
- 12 Oct, 2013 4 commits
-
-
Fabien Potencier authored
This PR was merged into the master branch. Discussion ---------- added a way to delay the attachment of a controller to a route There are several ideas behind this PR. It's mostly about consistency by being able to decouple the setting of a controller from the match call. The old way still works of course. It is more consistent as everything can now be done via method calls and the fact that the controller is the second argument makes things uglier, especially when the code in the controller is large. As an added bonus, it helps when indenting the code (currently, I always wonder how to indent my code as it's not obvious). Last, but not the least, being able to put the code last also makes things more readable. Current: ``` $app->get('/foo', function ($id) { // ... }) ->bind('home') ->assert('id', '\d+') ; ``` Now: ``` $app ->get('/foo') ->bind('home') ->assert('id', '\d+') ->run(function ($id) { // ... }) ; ``` Commits ------- 8fbb9369 added a way to delay the attachment of a controller to a route
-
Fabien Potencier authored
-
Fabien Potencier authored
-
Fabien Potencier authored
-
- 11 Oct, 2013 9 commits
-
-
Fabien Potencier authored
-
Fabien Potencier authored
This PR was merged into the master branch. Discussion ---------- added support for the Symfony HttpKernel fragment sub-framework Closes #783 and #802 Todo: - [x] add some tests Commits ------- dcbab7f6 added support for the Symfony HttpKernel fragment sub-framework
-
Fabien Potencier authored
-
Fabien Potencier authored
-
Fabien Potencier authored
This PR was merged into the master branch. Discussion ---------- Minor - Adding session dependency caution message Commits ------- 4eab2bd3 Update security.rst c0a54314 Minor - Adding session dependency caution message
-
Fabien Potencier authored
feature #772 Added "security.hide_user_not_found" support in SecurityServiceProvider (tomaszsobczak) This PR was squashed before being merged into the master branch (closes #772). Discussion ---------- Added "security.hide_user_not_found" support in SecurityServiceProvider Added "security.hide_user_not_found" support in SecurityServiceProvider to make configuration similar with Symfony2 framework. Commits ------- 9c614f5a Added "security.hide_user_not_found" support in SecurityServiceProvider
-
tomaszsobczak authored
-
Fabien Potencier authored
This PR was merged into the master branch. Discussion ---------- Add a link to github "How to create a pull request" article Commits ------- 6a0da1e3 Add a link to github "How to create a pull request" article
-
Fabien Potencier authored
-