This PR was squashed before being merged into the master branch (closes #565).

Commits
-------

55dce6b5 Test session service provider with routes that does not use session

Discussion
----------

Test session service provider with routes that does not use session

Hello,

Since symfony/Symfony@098b593591, a bug occurs with `SessionServiceProvider` :

When using `HttpKernel\Client`, setting `$app['session.test'] = true;` and querying the application multiple routes in a single unit test, a `RuntimeException` is thrown by `Symfony\Component\HttpFoundation\Session\Storage\MockFileSessionStorage`.

For instance :

```php
use Silex\WebTestCase;
use Silex\Application;
use Silex\Provider\SessionServiceProvider;

class unitTest extends WebTestCase
{
    public function testUn()
    {
        $client = $this->createClient();
        $client->request('GET', '/');
        $client->request('GET', '/');
    }

    public function createApplication()
    {
        $app = new Application();

        $app->register(new SessionServiceProvider(), array(
            'session.test' => true
        ));

        $app['debug'] = true;
        $app['exception_handler']->disable();

        $app->get('/', function(Application $app) {
            return 'BOOM';
        });

        return $app;
    }
}
```
results in
```
1) unitTest::testUn
RuntimeException: Trying to save a session that was not started yet or was already closed

/Users/romain/Documents/workspace/testSess/vendor/symfony/symfony/src/Symfony/Component/HttpFoundation/Session/Storage/MockFileSessionStorage.php:101
/Users/romain/Documents/workspace/testSess/vendor/symfony/symfony/src/Symfony/Component/HttpFoundation/Session/Session.php:184
/Users/romain/Documents/workspace/testSess/vendor/silex/silex/src/Silex/Provider/SessionServiceProvider.php:107
/Users/romain/Documents/workspace/testSess/vendor/symfony/symfony/src/Symfony/Component/EventDispatcher/EventDispatcher.php:164
/Users/romain/Documents/workspace/testSess/vendor/symfony/symfony/src/Symfony/Component/EventDispatcher/EventDispatcher.php:53
/Users/romain/Documents/workspace/testSess/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/HttpKernel.php:169
/Users/romain/Documents/workspace/testSess/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/HttpKernel.php:151
/Users/romain/Documents/workspace/testSess/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/HttpKernel.php:73
/Users/romain/Documents/workspace/testSess/vendor/silex/silex/src/Silex/Application.php:469
/Users/romain/Documents/workspace/testSess/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/Client.php:61
/Users/romain/Documents/workspace/testSess/vendor/symfony/symfony/src/Symfony/Component/BrowserKit/Client.php:264
/Users/romain/Documents/workspace/testSess/bingo.php:13
```

Of course, this test currently passes as the bug happens with latest `2.1.x-dev` source whereas `composer.json` settings ask to install latest stable tag.

This PR adds a test that fails with latest symfony 2.1.x.

---------------------------------------------------------------------------

by romainneutron at 2012-12-17T22:19:24Z

It seems the fix I've added is good enough, so, finally this PR brings a solution to the problem :)

This PR was merged into the master branch.

Commits
-------

490dd927 Replace double colons with valid PHP syntax

Discussion
----------

Replace double colons with valid PHP syntax

This PR was merged into the master branch.

Commits
-------

d2c42b32 Rename ErrorHandlerTest to ExceptionHandlerTest

Discussion
----------

Rename ErrorHandlerTest to ExceptionHandlerTest

This PR was merged into the master branch.

Commits
-------

332142f6 Document symfony/twig-bridge requirement for forms in twig templates

Discussion
----------

Document symfony/twig-bridge requirement for forms in twig templates

This PR was merged into the master branch.

Commits
-------

e04ec9f2 Rename BeforeAfterFilterTest to MiddlewareTest

Discussion
----------

Rename BeforeAfterFilterTest to MiddlewareTest

This PR was merged into the master branch.

Commits
-------

97d15149 getFormat() => getRequestFormat()

Discussion
----------

getFormat() => getRequestFormat()

The `getFormat()` method is not the one used to get the request format.

The `getFormat()` method is not the one used to get the request format.

This PR was merged into the master branch.

Commits
-------

84769fdd Make monolog documentation not condescending

Discussion
----------

Make monolog documentation not condescending

Docs regression from #551.

Docs regression from #551.

This PR was merged into the master branch.

Commits
-------

4772cbe7 Update doc/providers/serializer.rst

Discussion
----------

Update doc/providers/serializer.rst

fixed formatting for codeblocks

This PR was merged into the master branch.

Commits
-------

3c226283 Linked "How to make sub-requests" in usage doc

Discussion
----------

Linked "How to make sub-requests" in usage doc

Fixes #546.

---------------------------------------------------------------------------

by igorw at 2012-11-18T18:03:25Z

The example also needs to be fixed to pass the cookie and server bags.

This PR was merged into the master branch.

Commits
-------

a868919b Rename mount() argument from $app to $controllers

Discussion
----------

Rename mount() argument from $app to $controllers

App is a legacy name, the usage of the method has changed.

This PR was merged into the master branch.

Commits
-------

412c6d77 Removed unused use statement from the sample code

Discussion
----------

Removed unused use statement from the sample code

The sample code changed to not need the ControllerCollection anyone but the use statement was left in.

---------------------------------------------------------------------------

by igorw at 2012-11-26T02:35:33Z

👍

App is a legacy name, the usage of the method has changed

Fixes #546.

fixed formatting for codeblocks

This PR was squashed before being merged into the master branch (closes #539).

Commits
-------

7df7761c Example for DoctrineServiceProvider in session cookbook

Discussion
----------

Example for DoctrineServiceProvider in session cookbook

Adds an example for using the DoctrineServiceProvider with PdoSessionHandler.

---------------------------------------------------------------------------

by GromNaN at 2012-11-09T12:27:02Z

You should add section titles as the cookbook gives 2 ways to do the same thing.

---------------------------------------------------------------------------

by ChrisRiddell at 2012-11-09T12:35:50Z

@GromNaN Sorry still new to this what do you mean by section titles?

---------------------------------------------------------------------------

by GromNaN at 2012-11-09T12:43:52Z

The page contains 2 titles named "Example".
* 1st: name it "With a dedicated PDO service"
* 2nd: name it "Using the DoctrineServiceProvider" & move the text you added after the 2nd title.

---------------------------------------------------------------------------

by GromNaN at 2012-11-09T15:03:24Z

👍

This PR was merged into the master branch.

Commits
-------

4174a768 Define "magic" methods of \Silex\Controller

Discussion
----------

Define "magic" methods of \Silex\Controller

This makes IDEs (PHPStorm, in particular) a bit happier about route-definitions.
see http://manual.phpdoc.org/HTMLSmartyConverter/PHP/phpDocumentor/tutorial_tags.method.pkg.html

Controller forwards calls to Route using __call(), but, before this patch, IDEs do not know about this, and show warnings about non-existent methods: assert(), value(), etc.

This makes IDEs (PHPStorm, in particular) a bit happier about route-definitions.
see http://manual.phpdoc.org/HTMLSmartyConverter/PHP/phpDocumentor/tutorial_tags.method.pkg.html

This PR was merged into the master branch.

Commits
-------

969ae6d2 Link to web servers chapter from usage

Discussion
----------

Link to web servers chapter from usage

This PR was squashed before being merged into the master branch (closes #536).

Commits
-------

a9552481 Minor session documentation change.

Discussion
----------

Minor session documentation change.

Thanks to igorw in #silex-php, we were able to get our redis sessions
working in Silex. At his request, I'm updating the docs to indicate what
he came up with.

---------------------------------------------------------------------------

by igorw at 2012-11-08T18:26:20Z

Looks good, but please wrap the long line at 80 chars.

---------------------------------------------------------------------------

by igorw at 2012-11-08T19:04:07Z

👍

This PR was merged into the master branch.

Commits
-------

7d07da09 Update { => Native}FileSessionHandler in session doc

Discussion
----------

Update { => Native}FileSessionHandler in session doc

---------------------------------------------------------------------------

by indeyets at 2012-11-08T16:48:47Z

by the way, is non-native option still available somewhere?

---------------------------------------------------------------------------

by igorw at 2012-11-08T17:02:07Z

Yes. If you set the `session.test` parameter to true, it will use a `MockFileSessionStorage` instead. See also [the SessionServiceProvider docs](silex.sensiolabs.org/doc/providers/session.html).

This PR was merged into the master branch.

Commits
-------

d00ff5b1 Suggest removing the minimum-stability flag

Discussion
----------

Suggest removing the minimum-stability flag

Silex can be installed with stable versions of the Symfony2 components.
Users should not be encouraged to set the minimum-stability flag to dev.

https://groups.google.com/forum/?fromgroups=#!topic/silex-php/vPwMs7CMMT0

---------------------------------------------------------------------------

by igorw at 2012-11-07T23:50:52Z

I agree, it should also be adjusted in the usage doc (which is currently broken because it has neither `minimum-stability` nor `@dev`).

In fact this is already what is used in the skeletons.

This PR was merged into the master branch.

Commits
-------

4a0d746a Update doc/providers/security.rst

Discussion
----------

Update doc/providers/security.rst

typo is -> if

typo is -> if

Silex can be installed with stable versions of the components.

Revert "fixed a fatal error when the security provider is created without any firewalls (which of course does not make sense but anyways, refs #473)"

This reverts commit 2b28989b.

This PR was merged into the master branch.

Commits
-------

236ef89b Set SCRIPT_FILENAME after including params

Discussion
----------

Set SCRIPT_FILENAME after including params

I think that some versions or distributions of nginx set SCRIPT_FILENAME in the
fastcgi_params file (certainly ubuntu/debian), overriding anything previously set.

---------------------------------------------------------------------------

by igorw at 2012-11-06T14:21:18Z

Confirmed, ubuntu sets it:

    fastcgi_param   SCRIPT_FILENAME         $request_filename;