1. 02 Nov, 2013 1 commit
  2. 01 Nov, 2013 4 commits
    • Fabien Potencier's avatar
      Merge branch '1.1' · 44883022
      Fabien Potencier authored
      * 1.1:
        fixed translator locale management
        bumped version to 1.1.3-DEV
        prepared the 1.1.2 release
        updated CHANGELOG
        prepared the 1.0.2 release
        updated CHANGELOG
      
      Conflicts:
      	doc/changelog.rst
      	src/Silex/Application.php
      	src/Silex/Provider/TranslationServiceProvider.php
      44883022
    • Fabien Potencier's avatar
      bug #830 fixed translator locale management (fabpot) · d12b4177
      Fabien Potencier authored
      This PR was merged into the 1.1 branch.
      
      Discussion
      ----------
      
      fixed translator locale management
      
      The locale used by the translator was set the first time the translator was instantiated. That's a problem for several reasons:
      
       * changing the locale via `$app['locale']` would not change the locale used by the translator;
      
       * when using fragments, the locale was not updated correctly;
      
       * also, when using the web profiler, the translator is created early on (before the handling of a request), and so the locale was always `en` (see silexphp/Silex-WebProfiler#23).
      
      Commits
      -------
      
      902c2c8c fixed translator locale management
      d12b4177
    • Fabien Potencier's avatar
      fixed translator locale management · 902c2c8c
      Fabien Potencier authored
      902c2c8c
    • Fabien Potencier's avatar
      feature #828 Converters (fabpot) · bcb07f44
      Fabien Potencier authored
      This PR was merged into the master branch.
      
      Discussion
      ----------
      
      Converters
      
      This PR reverts #769 (which tried to fix #768) as this is a breaks BC for the most usual use case of converters (#806).
      
      The decision has been taken (#814) that a converter always run, independently of the available request attribute names or controller argument names.
      
      Because of the above, running the converters as a controller event is not needed anymore, and moving the converters earlier in the process gives more power to the developer (#825 and #826).
      
      Commits
      -------
      
      a0644877 Convert request attributes in the KernelEvents::REQUEST event instead of KernelEvents::CONTROLLER event (closes #825)
      3b207399 added a note about global  converters being applied to all controllers
      76776926 Revert "merged branch igorw/convert-only-existing-attribute (PR #769)"
      bcb07f44
  3. 31 Oct, 2013 6 commits
  4. 30 Oct, 2013 12 commits
  5. 29 Oct, 2013 1 commit
  6. 28 Oct, 2013 2 commits
  7. 26 Oct, 2013 4 commits
  8. 19 Oct, 2013 1 commit
  9. 16 Oct, 2013 4 commits
  10. 14 Oct, 2013 1 commit
  11. 13 Oct, 2013 1 commit
  12. 12 Oct, 2013 3 commits
    • Fabien Potencier's avatar
      feature #804 added a way to delay the attachment of a controller to a route (fabpot) · 2b966973
      Fabien Potencier authored
      This PR was merged into the master branch.
      
      Discussion
      ----------
      
      added a way to delay the attachment of a controller to a route
      
      There are several ideas behind this PR. It's mostly about consistency by being able to decouple the setting of a controller from the match call. The old way still works of course.
      
      It is more consistent as everything can now be done via method calls and the fact that the controller is the second argument makes things uglier, especially when the code in the controller is large.
      
      As an added bonus, it helps when indenting the code (currently, I always wonder how to indent my code as it's not obvious). Last, but not the least, being able to put the code last also makes things more readable.
      
      Current:
      
      ```
      $app->get('/foo', function ($id) {
          // ...
      })
      ->bind('home')
      ->assert('id', '\d+')
      ;
      ```
      
      Now:
      
      ```
      $app
          ->get('/foo')
          ->bind('home')
          ->assert('id', '\d+')
          ->run(function ($id) {
              // ...
          })
      ;
      ```
      
      Commits
      -------
      
      8fbb9369 added a way to delay the attachment of a controller to a route
      2b966973
    • Fabien Potencier's avatar
    • Fabien Potencier's avatar
      removed obsolete check in a test · 7134febb
      Fabien Potencier authored
      7134febb