1. 14 Mar, 2017 1 commit
  2. 19 Feb, 2017 1 commit
  3. 01 Feb, 2017 1 commit
  4. 09 Jan, 2017 1 commit
  5. 08 Jan, 2017 1 commit
  6. 06 Jan, 2017 2 commits
  7. 02 Jan, 2017 2 commits
  8. 06 Dec, 2016 5 commits
  9. 23 Nov, 2016 2 commits
  10. 22 Nov, 2016 3 commits
  11. 21 Nov, 2016 2 commits
  12. 06 Nov, 2016 13 commits
  13. 30 Oct, 2016 2 commits
  14. 12 Oct, 2016 1 commit
  15. 07 Oct, 2016 1 commit
  16. 06 Oct, 2016 1 commit
  17. 03 Oct, 2016 1 commit
    • Fabien Potencier's avatar
      bug #1431 Move setting $app['twig.app_variable'] after 'Symfony\Bridge\Twig' check (tiemevanveen) · 0115e23e
      Fabien Potencier authored
      This PR was merged into the 2.0.x-dev branch.
      
      Discussion
      ----------
      
      Move setting $app['twig.app_variable'] after 'Symfony\Bridge\Twig' check
      
      Currently `TwigServiceProvider ` sets `$app['twig.app_variable']` to be function that has a dependency on classes that are not required by Silex. This will fail if the user then calls that function. This happens for example when the [silex-pimple-dumper](https://github.com/Sorien/silex-pimple-dumper) maps over the app and tries to dump it's content.
      
      This PR fixes that by moving this in the `class_exists('Symfony\Bridge\Twig\Extension\RoutingExtension')` check.
      
      I've also added comment because at first it wasn't clear for me that this check for the `RoutingExtension` was the check for the whole Twig bridge. Please feel free to rebase and remove it it you don't like it or I misinterpreted it.
      
      Keep up the good work! 👍
      
      Commits
      -------
      
      b97f5a89 Move setting $app['twig.app_variable'] after 'Symfony\Bridge\Twig' check
      0115e23e