- 21 Aug, 2013 1 commit
-
-
Fabien Potencier authored
This PR was merged into the master branch. Discussion ---------- Remove usage of deprecated function getPattern() Found another one. Did also some search now and there is no set/get-Pattern anymore. Commits ------- 36be14f9 Remove usage of deprecated function getPattern()
-
- 19 Aug, 2013 1 commit
-
-
Daniel Tschinder authored
-
- 15 Aug, 2013 2 commits
-
-
Fabien Potencier authored
This PR was merged into the master branch. Discussion ---------- Remove usage of deprecated function Remove usage of deprecated function setPattern() and replace with replacement function setPath(). I was not sure if we also want to rename the variables/arguments $pattern to $path inside silex. For now i haven't touched them. Commits ------- 3b4895de Remove usage of deprecated function setPattern()
-
Daniel Tschinder authored
and replace with replacement function setPath()
-
- 27 Jul, 2013 4 commits
-
-
Fabien Potencier authored
-
Fabien Potencier authored
This PR was merged into the master branch. Discussion ---------- Adjust docs on how to enable logger service Commits ------- 9ba29bde Adjust docs on how to enable logger service
-
Fabien Potencier authored
-
Fabien Potencier authored
This PR was merged into the master branch. Discussion ---------- Log the target url when redirecting I've modified the monolog provider to also log the target url when the response is a `RedirectResponse`. Also added a test for it. Commits ------- 3f746692 Log the target url when redirecting
-
- 26 Jul, 2013 1 commit
-
-
Gábor Fási authored
-
- 19 Jul, 2013 3 commits
-
-
Fabien Potencier authored
This PR was squashed before being merged into the master branch (closes #753). Discussion ---------- Lower the priority of the exception logging Fixes #752 I'd like this to be lower, `Symfony\Component\HttpKernel\EventListener\ExceptionListener` has this functionality at [-128](https://github.com/webfactory/symfony/blob/6b64c03e4a92d071263b3c5c765de166106f2d2e/src/Symfony/Component/HttpKernel/EventListener/ExceptionListener.php#L84), but the default priority for handlers added with `Silex\Application::error` fire at -8, so I thought there would be fewer wtfs if we stay above that? Commits ------- b6f72c2d Lower the priority of the exception logging
-
Dave Marshall authored
-
Fabien Potencier authored
This PR was merged into the master branch. Discussion ---------- missing word simple documentation fix because of missing word in a comment. Commits ------- d25a75b2 missing word
-
- 18 Jul, 2013 1 commit
-
-
opatry authored
-
- 16 Jul, 2013 1 commit
-
-
Fabien Potencier authored
This PR was merged into the master branch. Discussion ---------- Update internals.rst Fixed minor typo and added a missing comma in the same sentence. Commits ------- a38db51a Update internals.rst
-
- 15 Jul, 2013 1 commit
-
-
nleduc authored
Fixed minor typo and added a missing comma in the same sentence.
-
- 04 Jul, 2013 10 commits
-
-
Igor Wiedler authored
-
Fabien Potencier authored
-
Fabien Potencier authored
-
Fabien Potencier authored
-
Fabien Potencier authored
* 1.0: bumped version to 1.0.2-DEV prepared the 1.0.1 release updated CHANGELOG for 1.0 added a unit test for previous merge (refs #706) Fixed typo in the ServiceProviderInterface interface PHPDoc block. Add note on how to handle fatal errors, as per mailing list Alter app references in middleware doc Make DoctrineServiceProvider db connection lazy Workaround for OptionsResolver validating options add '_route' key to RedirectableUrlMatcher::redirect reflect change: Modularity chapter renamed to Organizing Controllers (#570) Add target branch notes Fixed namespace path Conflicts: doc/changelog.rst src/Silex/Application.php tests/Silex/Tests/Provider/ValidatorServiceProviderTest.php
-
Fabien Potencier authored
-
Fabien Potencier authored
-
Fabien Potencier authored
-
Fabien Potencier authored
-
Fabien Potencier authored
-
- 03 Jul, 2013 12 commits
-
-
Fabien Potencier authored
This PR was merged into the master branch. Discussion ---------- Introduced new symfony Debug component for error_handler cookbook Just fix the error_handler cookbook now use the Symfony Debug Component. Commits ------- 145b48a0 Introduced new symfony Debug component for error_handler cookbook
-
Fabien Potencier authored
-
Fabien Potencier authored
This PR was merged into the 1.0 branch. Discussion ---------- add '_route' key to RedirectableUrlMatcher::redirect When there is a logger, the Symfony\Compoment\HttpKernel\EventListener\RouterListener::onKernelRequest method expects the '_route' key to exist in order to log the matched route and issues a PHP Notice <?php date_default_timezone_set('America/Los_Angeles'); require_once __DIR__ . '/../vendor/autoload.php'; Symfony\Component\HttpKernel\Debug\ErrorHandler::register(); $app = new Silex\Application(); $app['debug'] = true; $app['monolog.logfile'] = 'C:/TEMP/log.log'; $app->register(new \Silex\Provider\MonologServiceProvider()); $app->get('/a/', function() { return 'done'; }); $app->run(); *[url]/a* issues the notice before redirecting to */a/* Commits ------- 3d1a868c add '_route' key to RedirectableUrlMatcher::redirect
-
Fabien Potencier authored
This PR was squashed before being merged into the master branch (closes #710). Discussion ---------- Added swiftmailers second argument for the send function within the SwiftmailerTrait Commits ------- 78115b47 Added swiftmailers second argument for the send function within the SwiftmailerTrait
-
NLZ13 authored
-
Barney Hanlon authored
Updated require-dev to have phpunit at a safe enough version, and updated the documentation to reflect the change. (closes #727)
-
Fabien Potencier authored
This PR was squashed before being merged into the master branch (closes #713). Discussion ---------- Added instructions for installing dev testing package As per [discussion about this requirement](https://groups.google.com/d/topic/silex-php/FfgPucE2Bu4/discussion). Commits ------- 862cf398 Added instructions for installing dev testing package
-
Tobias Sjösten authored
-
Fabien Potencier authored
This PR was squashed before being merged into the master branch (closes #741). Discussion ---------- Change the ControllerResolver type hint to Psr\\Log\\LoggerInterface This allows it to work with any logger, in particular, it un-breaks the case where the monolog bridge is not installed. See also 817240e4. This should resolve #740. Commits ------- b85d610d Change the ControllerResolver type hint to Psr\Log\LoggerInterface
-
Igor Wiedler authored
-
Fabien Potencier authored
This PR was merged into the 1.0 branch. Discussion ---------- Add note on how to handle fatal errors I'm not so happy with this solution from a usability perspective, but I don't want to have global error handlers in silex itself. An option we could consider is making symfony's ErrorHandler fall back to an internal ``ExceptionHandler`` for fatal errors. But obviously that is not very elegant either. Ideas welcome. Commits ------- 7a222ce5 Add note on how to handle fatal errors, as per mailing list
-
Fabien Potencier authored
This PR was merged into the master branch. Discussion ---------- Override the logger service by default Fixes #731 Been sat on this for a while, not been able to think of anything else that needs doing for it. Commits ------- 817240e4 Override the logger service by default
-
- 02 Jul, 2013 1 commit
-
-
Dave Marshall authored
-
- 30 Jun, 2013 1 commit
-
-
Fabien Potencier authored
This PR was merged into the 1.0 branch. Discussion ---------- Fixed typo in the ServiceProviderInterface interface PHPDoc block. Commits ------- 8bf3f788 Fixed typo in the ServiceProviderInterface interface PHPDoc block.
-
- 29 Jun, 2013 1 commit
-
-
Hugo Hamon authored
-