1. 24 May, 2012 10 commits
  2. 21 May, 2012 9 commits
    • Thibaut Cuvelier's avatar
      fixed typos (closes #240) · 6dcb2587
      Thibaut Cuvelier authored
      6dcb2587
    • Fabien Potencier's avatar
    • Fabien Potencier's avatar
      fixed exception handling · b3fc523b
      Fabien Potencier authored
      b3fc523b
    • Chris Ramakers's avatar
      cb5003a0
    • Fabien Potencier's avatar
      merged branch fabpot/global_route_settings (PR #326) · cbb1113f
      Fabien Potencier authored
      Commits
      -------
      
      eaf176d3 added a Route class
      e3ddad54 added the possibility for settings set on a controller collection to influence controllers register later on
      0356873a changed Controller::generateRouteName() visibility
      31652440 added a way to define settings for all routes of a collection (closes #186)
      
      Discussion
      ----------
      
      added a way to define settings for all routes of a collection (closes #186)
      
      see the ticket and docs from the patch.
      
      ---------------------------------------------------------------------------
      
      by fabpot at 2012-05-21T13:00:13Z
      
      ok, I've changed the strategy to what I've described above. ping @igorw
      
      ---------------------------------------------------------------------------
      
      by igorw at 2012-05-21T16:09:56Z
      
      `ControllerCollection extends Controller` is weird. I see how some code can be re-used, but a controller cannot be frozen or named, so those parts don't really make sense to me.
      
      Apart from that it's a nice feature. If you can come up with a cleaner way to do it that doesn't bloat the code too much, that'd be nice.
      
      ---------------------------------------------------------------------------
      
      by fabpot at 2012-05-21T16:30:16Z
      
      What about creating a `Route` class that extends the Symfony `Route` class? It would contain the `assert`, `value`, `requireHttp`, `requireHttps`, `convert`, and `middleware` methods. Then, `Controller` and `ControllerCollection` extend this new `Route` class.
      
      ---------------------------------------------------------------------------
      
      by fabpot at 2012-05-21T16:33:23Z
      
      Extending the `Route` is not necessarily a good idea either. What about creating this `Route` class and compose it into both `Controller` and `ControllerCollection`?
      
      ---------------------------------------------------------------------------
      
      by fabpot at 2012-05-21T16:33:50Z
      
      That's what my last commit does.
      
      ---------------------------------------------------------------------------
      
      by fabpot at 2012-05-21T16:36:34Z
      
      By the way, a Trait would probably have been the best solution.
      cbb1113f
    • Fabien Potencier's avatar
      added a Route class · eaf176d3
      Fabien Potencier authored
      eaf176d3
    • Fabien Potencier's avatar
      added the possibility for settings set on a controller collection to influence... · e3ddad54
      Fabien Potencier authored
      added the possibility for settings set on a controller collection to influence controllers register later on
      e3ddad54
    • Fabien Potencier's avatar
      0356873a
    • Fabien Potencier's avatar
  3. 20 May, 2012 16 commits
  4. 19 May, 2012 3 commits
  5. 16 May, 2012 1 commit
  6. 15 May, 2012 1 commit