1. 23 Jul, 2017 3 commits
  2. 20 Jul, 2017 1 commit
  3. 15 Jun, 2017 12 commits
    • Fabien Potencier's avatar
      fixed CS · 74d9869d
      Fabien Potencier authored
      74d9869d
    • Fabien Potencier's avatar
      minor #1482 Update documentation to add cache explaination (jlHertel) · 85bff8cb
      Fabien Potencier authored
      This PR was merged into the 2.1.x-dev branch.
      
      Discussion
      ----------
      
      Update documentation to add cache explaination
      
      This updates the documentation explaining how to setup any cache that implements the Doctrine interface. As the Symfony documentation don't clearly shows how to do this, I intend to add it here.
      
      Commits
      -------
      
      2e0f7d38 Update documentation to add cache explaination
      85bff8cb
    • Fabien Potencier's avatar
      bug #1522 Error using EsiFragment with provider and twig functions (mihailov-vf) · 6260671f
      Fabien Potencier authored
      This PR was merged into the 2.1.x-dev branch.
      
      Discussion
      ----------
      
      Error using EsiFragment with provider and twig functions
      
      Trying to use twig functions "controller" and "render_esi" like [Symfony esi reference](http://symfony.com/doc/current/http_cache/esi.html) , i've noticed the following error:
      An exception has been thrown during the rendering of a template ("You must use a URI when using the ESI rendering strategy or set a URL signer.").
      
      It's the lack of a UriSigner on the constructor.
      
      Commits
      -------
      
      c6bbc48b Update HttpFragmentServiceProvider.php
      6260671f
    • Fabien Potencier's avatar
      feature #1518 add json manifest version strategy support (MatTheCat) · 9cbf194d
      Fabien Potencier authored
      This PR was merged into the 2.1.x-dev branch.
      
      Discussion
      ----------
      
      add json manifest version strategy support
      
      Commits
      -------
      
      65382f4c add json manifest version strategy support
      9cbf194d
    • Fabien Potencier's avatar
      bug #1534 RedirectableUrlMatcher needs to return a proper array with the _route parameter (slipo) · 268e3d33
      Fabien Potencier authored
      This PR was merged into the 2.1.x-dev branch.
      
      Discussion
      ----------
      
      RedirectableUrlMatcher needs to return a proper array with the _route parameter
      
      Symfony's HttpUtils's checkRequestPath() expects RedirectableUrlMatcher to return an array with '_route'. This throws a notice `Undefined index: _route`:
      
      ```
              $coll = new RouteCollection();
              $coll->add('foo', new Route('/foo', array(), array(), array(), '', array('https')));
              $matcher = new RedirectableUrlMatcher($coll, new RequestContext());
              $httpUtils = new HttpUtils(null, $matcher);
              $request = Request::create('http://example.com/foo');
              $httpUtils->checkRequestPath($request, 'foo');
      ```
      
      It's an issue with my app although I haven't yet taken the time to make a simplified app to show the issue besides the above.
      
      Commits
      -------
      
      e6d41b8d RedirectableUrlMatcher needs to return a proper array with the _route parameter
      268e3d33
    • Fabien Potencier's avatar
      minor #1529 Added test of FormTrait::namedForm() (chihiro-adachi) · 56dfd325
      Fabien Potencier authored
      This PR was squashed before being merged into the 2.1.x-dev branch (closes #1529).
      
      Discussion
      ----------
      
      Added test of FormTrait::namedForm()
      
      I did not see the test of FormTrait::namedForm(), so I created it.
      
      Commits
      -------
      
      32640626 Added test of FormTrait::namedForm()
      56dfd325
    • chihiro-adachi's avatar
      Added test of FormTrait::namedForm() · 32640626
      chihiro-adachi authored
      32640626
    • Fabien Potencier's avatar
      minor #1523 Test all the 3.x branches in Travis (skalpa) · 8e187c12
      Fabien Potencier authored
      This PR was squashed before being merged into the 2.1.x-dev branch (closes #1523).
      
      Discussion
      ----------
      
      Test all the 3.x branches in Travis
      
      I enhanced the Travis config to ensure the tests are run against all the available 3.x branches.
      
      Before the changes:
      - The tests were run against `2.8` when `$SYMFONY_DEPS_VERSION` was unset
      - There were additional envs for `3.0`, `3.1` and `3.2`
      
      After the changes:
      - When `$SYMFONY_DEPS_VERSION` is unset, `composer.json` is left unchanged and the tests are run against the most recent `3.x-dev` branch (what you'd get by running phpunit locally)
      - There are envs to test all the symfony branches from `2.8` to `3.3`
      
      I also fixed the cache (there were two `cache/directories` sections) and made the syntax more consistent overall.
      
      This changes the behaviors of the build: before, `Twig 2.x` was tested with `2.8`. Now, it is tested alongside the most recent `3.x`. I believe it makes more sense like this, however if the old behavior was on purpose (i.e because `2.8` is still the most recent _lts_), I can still switch back and add envs for `3.3` and `3.4` instead.
      
      Regarding the changes to the tests:
      
      I originally removed `symfony/web-link` from the list of dependencies when testing against `< 3.3`, as something like this will be necessary later when adding `symfony/cache` support which conflicts with `symfony/var-dumper < 3.3`.
      
      However, as this was not necessary and actually prevented us to check that the WebLink integration didn't break when the component was available but associated with an old version of the `twig-bridge`, I ultimately rolled back the change. Yet, I kept the checks in the tests as they are cleaner this way IMO (anyway they're in a separate commit so I could just remove them too if you want).
      
      Commits
      -------
      
      5557944d Test all the 3.x branches in Travis
      8e187c12
    • Pascal Luna's avatar
      Test all the 3.x branches in Travis · 5557944d
      Pascal Luna authored
      5557944d
    • Fabien Potencier's avatar
      fixed CS · 77e86f11
      Fabien Potencier authored
      77e86f11
    • Fabien Potencier's avatar
      minor #1532 Docs: Update interface reference for csrf.token_manager (thisisandrew) · 682e1a56
      Fabien Potencier authored
      This PR was merged into the 2.1.x-dev branch.
      
      Discussion
      ----------
      
      Docs: Update interface reference for csrf.token_manager
      
      The csrf.token_manager is an implementation of CsrfTokenManagerInterface
      Fix the label and link to the reference
      Update Usage section to include creation of a new token
      
      Commits
      -------
      
      0a0c2d9e Update interface reference for csrf.token_manager
      682e1a56
    • MatTheCat's avatar
      add json manifest version strategy support · 65382f4c
      MatTheCat authored
      65382f4c
  4. 12 Jun, 2017 3 commits
  5. 10 Jun, 2017 1 commit
  6. 02 Jun, 2017 2 commits
  7. 19 May, 2017 3 commits
  8. 14 May, 2017 3 commits
    • Fabien Potencier's avatar
      tweaked an example · 694fe555
      Fabien Potencier authored
      694fe555
    • Fabien Potencier's avatar
      minor #1517 Clarify documentations around protected closures. (jordanlev) · c7a108a1
      Fabien Potencier authored
      This PR was merged into the 2.1.x-dev branch.
      
      Discussion
      ----------
      
      Clarify documentations around protected closures.
      
      The docs state that "protected closures do not get access to the container", but this is somewhat misleading (it confused me for a quite some time). It's true that protected closures are not passed the container as a function argument, but they can access the container via `use ($app)`.
      
      Commits
      -------
      
      45d9113d Clarify documentations around protected closures.
      c7a108a1
    • Jordan Lev's avatar
      Clarify documentations around protected closures. · 45d9113d
      Jordan Lev authored
      The docs state that "protected closures do not get access to the container", but this is somewhat misleading (it confused me for a quite some time). It's true that protected closures are not passed the container as a function argument, but they can access the container via `use ($app)`.
      45d9113d
  9. 09 May, 2017 4 commits
  10. 03 May, 2017 8 commits