1. 27 Jul, 2013 1 commit
    • Fabien Potencier's avatar
      merged branch maerlyn/master (PR #756) · ef44966f
      Fabien Potencier authored
      This PR was merged into the master branch.
      
      Discussion
      ----------
      
      Log the target url when redirecting
      
      I've modified the monolog provider to also log the target url when the response is a `RedirectResponse`. Also added a test for it.
      
      Commits
      -------
      
      3f746692 Log the target url when redirecting
      ef44966f
  2. 26 Jul, 2013 1 commit
  3. 19 Jul, 2013 3 commits
  4. 18 Jul, 2013 1 commit
  5. 16 Jul, 2013 1 commit
  6. 15 Jul, 2013 1 commit
    • nleduc's avatar
      Update internals.rst · a38db51a
      nleduc authored
      Fixed minor typo and added a missing comma in the same sentence.
      a38db51a
  7. 04 Jul, 2013 9 commits
  8. 03 Jul, 2013 12 commits
  9. 02 Jul, 2013 1 commit
  10. 30 Jun, 2013 1 commit
    • Fabien Potencier's avatar
      merged branch hhamon/phpdoc (PR #738) · 2ba7d326
      Fabien Potencier authored
      This PR was merged into the 1.0 branch.
      
      Discussion
      ----------
      
      Fixed typo in the ServiceProviderInterface interface PHPDoc block.
      
      Commits
      -------
      
      8bf3f788 Fixed typo in the ServiceProviderInterface interface PHPDoc block.
      2ba7d326
  11. 29 Jun, 2013 1 commit
  12. 24 Jun, 2013 1 commit
  13. 19 Jun, 2013 2 commits
    • Fabien Potencier's avatar
      merged branch TomAdam/pr-update-middleware-doc (PR #725) · d8776876
      Fabien Potencier authored
      This PR was submitted for the master branch but it was merged into the 1.0 branch instead (closes #725).
      
      Discussion
      ----------
      
      Alter app references in middleware doc
      
      I use ControllerProvider's and functions for my controllers, and I rely on the ````Application```` and ````Request```` being injected via the parameters of each function. Today I happened to need to build some middleware, but found that ````public function before(Application $app)```` resulted in a fatal as the middleware does not use type hinting to set parameters like controllers do. On digging a bit deeper I found in ````Silex\EventListener\MiddlewareListener.php::onKernelRequest```` the following line:
      ````
      $ret = call_user_func($callback, $request, $this->app);
      ````
      This injects application as the second parameter. I'm really happy that it does do this, but the parameter order seems a little strange to me. It's a bit at odds with the rest of the documentation on controllers - the general method prototype is ````method(Application $app, Request $request)````. Given this, I would have expected the app to come first in the parameter list. The same applies to the after callback, except it has ````Response```` between ````Request```` and ````Application````.
      
      The global middleware defined in ````Application```` do not inject the app in any of the callbacks, confusing the matter further. My pattern doesn't actually require this, but some people's might. Is there a reason this hasn't been done? It would be very simple to add, given the three methods are inside the ````Application```` class itself.
      
      The ideal fix to this would be that the middleware use type hinting to apply the parameters, but this is complicated by the callbacks occurring in two classes, neither of which are local to the existing type hinting code. At the very least I think this functionality should be documented, so this is what I have provided in the PR.
      
      Commits
      -------
      
      ddc9b92 Alter app references in middleware doc
      d8776876
    • Tom Adam's avatar
      Alter app references in middleware doc · 120bfa9a
      Tom Adam authored
      120bfa9a
  14. 06 Jun, 2013 4 commits
  15. 04 Jun, 2013 1 commit