- 23 Jul, 2017 3 commits
-
-
Fabien Potencier authored
-
Fabien Potencier authored
-
Fabien Potencier authored
This PR was merged into the 2.1.x-dev branch. Discussion ---------- Fixed translator.resources definition `translator.resource` is wrongly registered as a protected closure in `TranslationServiceProvider` (it was originally added correctly in dd270386, but changed in 48a3fdc4). That makes a test fail with Pimple 3.2.1 due to the silexphp/Pimple#190 fix as `translator.resource` can't be extended. Commits ------- c5dc42a7 Fixed translator.resources definition
-
- 20 Jul, 2017 1 commit
-
-
Pascal Luna authored
-
- 15 Jun, 2017 12 commits
-
-
Fabien Potencier authored
-
Fabien Potencier authored
This PR was merged into the 2.1.x-dev branch. Discussion ---------- Update documentation to add cache explaination This updates the documentation explaining how to setup any cache that implements the Doctrine interface. As the Symfony documentation don't clearly shows how to do this, I intend to add it here. Commits ------- 2e0f7d38 Update documentation to add cache explaination
-
Fabien Potencier authored
This PR was merged into the 2.1.x-dev branch. Discussion ---------- Error using EsiFragment with provider and twig functions Trying to use twig functions "controller" and "render_esi" like [Symfony esi reference](http://symfony.com/doc/current/http_cache/esi.html) , i've noticed the following error: An exception has been thrown during the rendering of a template ("You must use a URI when using the ESI rendering strategy or set a URL signer."). It's the lack of a UriSigner on the constructor. Commits ------- c6bbc48b Update HttpFragmentServiceProvider.php
-
Fabien Potencier authored
This PR was merged into the 2.1.x-dev branch. Discussion ---------- add json manifest version strategy support Commits ------- 65382f4c add json manifest version strategy support
-
Fabien Potencier authored
This PR was merged into the 2.1.x-dev branch. Discussion ---------- RedirectableUrlMatcher needs to return a proper array with the _route parameter Symfony's HttpUtils's checkRequestPath() expects RedirectableUrlMatcher to return an array with '_route'. This throws a notice `Undefined index: _route`: ``` $coll = new RouteCollection(); $coll->add('foo', new Route('/foo', array(), array(), array(), '', array('https'))); $matcher = new RedirectableUrlMatcher($coll, new RequestContext()); $httpUtils = new HttpUtils(null, $matcher); $request = Request::create('http://example.com/foo'); $httpUtils->checkRequestPath($request, 'foo'); ``` It's an issue with my app although I haven't yet taken the time to make a simplified app to show the issue besides the above. Commits ------- e6d41b8d RedirectableUrlMatcher needs to return a proper array with the _route parameter
-
Fabien Potencier authored
This PR was squashed before being merged into the 2.1.x-dev branch (closes #1529). Discussion ---------- Added test of FormTrait::namedForm() I did not see the test of FormTrait::namedForm(), so I created it. Commits ------- 32640626 Added test of FormTrait::namedForm()
-
chihiro-adachi authored
-
Fabien Potencier authored
This PR was squashed before being merged into the 2.1.x-dev branch (closes #1523). Discussion ---------- Test all the 3.x branches in Travis I enhanced the Travis config to ensure the tests are run against all the available 3.x branches. Before the changes: - The tests were run against `2.8` when `$SYMFONY_DEPS_VERSION` was unset - There were additional envs for `3.0`, `3.1` and `3.2` After the changes: - When `$SYMFONY_DEPS_VERSION` is unset, `composer.json` is left unchanged and the tests are run against the most recent `3.x-dev` branch (what you'd get by running phpunit locally) - There are envs to test all the symfony branches from `2.8` to `3.3` I also fixed the cache (there were two `cache/directories` sections) and made the syntax more consistent overall. This changes the behaviors of the build: before, `Twig 2.x` was tested with `2.8`. Now, it is tested alongside the most recent `3.x`. I believe it makes more sense like this, however if the old behavior was on purpose (i.e because `2.8` is still the most recent _lts_), I can still switch back and add envs for `3.3` and `3.4` instead. Regarding the changes to the tests: I originally removed `symfony/web-link` from the list of dependencies when testing against `< 3.3`, as something like this will be necessary later when adding `symfony/cache` support which conflicts with `symfony/var-dumper < 3.3`. However, as this was not necessary and actually prevented us to check that the WebLink integration didn't break when the component was available but associated with an old version of the `twig-bridge`, I ultimately rolled back the change. Yet, I kept the checks in the tests as they are cleaner this way IMO (anyway they're in a separate commit so I could just remove them too if you want). Commits ------- 5557944d Test all the 3.x branches in Travis
-
Pascal Luna authored
-
Fabien Potencier authored
-
Fabien Potencier authored
This PR was merged into the 2.1.x-dev branch. Discussion ---------- Docs: Update interface reference for csrf.token_manager The csrf.token_manager is an implementation of CsrfTokenManagerInterface Fix the label and link to the reference Update Usage section to include creation of a new token Commits ------- 0a0c2d9e Update interface reference for csrf.token_manager
-
MatTheCat authored
-
- 12 Jun, 2017 3 commits
-
-
Silas Albrecht authored
-
Fabien Potencier authored
This PR was merged into the 2.1.x-dev branch. Discussion ---------- Remove outdated example code from documentation The `user` method hasn't been part of the security trait since 7052d972 over 2 years ago. Commits ------- 7367244f Remove outdated example code from documentation
-
Jonathan Vollebregt authored
The `user` method hasn't been part of the security trait since 7052d972 over 2 years ago.
-
- 10 Jun, 2017 1 commit
-
-
Andrew J. Hill authored
The csrf.token_manager is an implementation of CsrfTokenManagerInterface Fix the label and link to the reference Update Usage section to include creation of a new token
-
- 02 Jun, 2017 2 commits
-
-
Fabien Potencier authored
This PR was squashed before being merged into the 2.1.x-dev branch (closes #1528). Discussion ---------- Fix exception hander test In symfony 3.3.0, the markup of the error wording has been changed. https://github.com/symfony/symfony/pull/22838 3.2.x `<h1>$title</h1>` 3.3.0 `<h1 class="break-long-words exception-message">$title</h1>` Therefore, in the symfony 3.3.0 environment, ExceptionHandlerTest fails. ``` 1) Silex \ Tests \ ExceptionHandlerTest :: testExceptionHandlerExceptionNoDebug Failed asserting that '<! DOCTYPE html> ... Contains "<h1> Whoops, looks like something went wrong. </h1>". ``` https://github.com/symfony/symfony/pull/22838/files#diff-5a9ac37e71d14aa261fe6f68848a6277L42 I deleted `<h1>` by referring to it. Commits ------- 69e2771b Fix exception hander test
-
chihiro-adachi authored
-
- 19 May, 2017 3 commits
-
-
Mihailov Vasilievic Filho authored
Trying to use twig functions "controller" and "render_esi" like [Symfony esi reference](http://symfony.com/doc/current/http_cache/esi.html) , i've noticed the following error: An exception has been thrown during the rendering of a template ("You must use a URI when using the ESI rendering strategy or set a URL signer."). It's the lack of a UriSigner on the constructor.
-
Fabien Potencier authored
This PR was squashed before being merged into the 2.1.x-dev branch (closes #1521). Discussion ---------- Update web_servers.rst Reformat code listing <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/silexphp/silex/1521) <!-- Reviewable:end --> Commits ------- 6b9319ac Update web_servers.rst
-
Denis K authored
-
- 14 May, 2017 3 commits
-
-
Fabien Potencier authored
-
Fabien Potencier authored
This PR was merged into the 2.1.x-dev branch. Discussion ---------- Clarify documentations around protected closures. The docs state that "protected closures do not get access to the container", but this is somewhat misleading (it confused me for a quite some time). It's true that protected closures are not passed the container as a function argument, but they can access the container via `use ($app)`. Commits ------- 45d9113d Clarify documentations around protected closures.
-
Jordan Lev authored
The docs state that "protected closures do not get access to the container", but this is somewhat misleading (it confused me for a quite some time). It's true that protected closures are not passed the container as a function argument, but they can access the container via `use ($app)`.
-
- 09 May, 2017 4 commits
-
-
Fabien Potencier authored
This PR was squashed before being merged into the 2.1.x-dev branch (closes #1514). Discussion ---------- Fixed WebTestCase compatibility with PHPUnit 6+ Makes `WebTestCase` inherit from `PHPUnit\Framework\TestCase` instead of `PHPUnit_Framework_TestCase`. Strictly speaking it's a BC break, but as the namespaced class is now available in PHPUnit 4.8.35, 5.4+ and 6.x it's probable safe. Commits ------- 619018a7 Fixed WebTestCase compatibility with PHPUnit 6+
-
Pascal Luna authored
-
Fabien Potencier authored
This PR was squashed before being merged into the 2.1.x-dev branch (closes #1515). Discussion ---------- Use PHPUnit\Framework\TestCase in Silex tests I changed all the tests so they use the namespaced class instead of `PHPUnit_Framework_TestCase`. That doesn't really bring anything, but will be one less thing to change when Silex switches to PHP7/PHPUnit 6. Commits ------- f8731dad Use PHPUnit\Framework\TestCase in Silex tests
-
Pascal Luna authored
-
- 03 May, 2017 8 commits
-
-
Fabien Potencier authored
-
Fabien Potencier authored
-
Fabien Potencier authored
-
Fabien Potencier authored
-
Fabien Potencier authored
This PR was merged into the 2.1.x-dev branch. Discussion ---------- Update session.rst to explain handlers Expand the documentation to explain how to use different session providers. Commits ------- a925171a Update session.rst to explain handlers
-
Fabien Potencier authored
This PR was merged into the 2.1.x-dev branch. Discussion ---------- Update guard_authentication.rst isPasswordValid() needs hashed password, not plaintext. Commits ------- 1a86c8ac Update guard_authentication.rst
-
Fabien Potencier authored
This PR was merged into the 2.1.x-dev branch. Discussion ---------- Update web_servers.rst Just another option for Apache that works Commits ------- d639b447 Update web_servers.rst
-
Fabien Potencier authored
-