Commits
-------

28c1b4c1 Added Twig_Extension_Debug if app is in debug mode

Discussion
----------

Added Twig_Extension_Debug if app is in debug mode

---------------------------------------------------------------------------

by stof at 2012-04-16T21:51:12Z

This was done initially in the PR adding it. But it has been reverted to avoid hard-to-debug issues when you have a template containing a dump call (it would work properly in your dev environment but throw an exception in your prod environment)

---------------------------------------------------------------------------

by lyrixx at 2012-05-12T14:12:09Z

@stof but it's very usefull ... more over, every dev add this extension.

---------------------------------------------------------------------------

by stof at 2012-05-12T23:36:27Z

@lyrixx The issue is that if it will be added only in debug mode and you forget to remove a dump call from your template, it will work properly in your dev environment (where Twig will be in debug mode with the extension) whereas the compilation of the template will fail in prod (because the function will not be defined anymore)

---------------------------------------------------------------------------

by lyrixx at 2012-05-13T13:21:20Z

@stof Yes I understood. I did the patch... But every time, on a new projet, I copy/paste these lines to my projet. And I am not the only one. So I think we could add this feature into silex. (And why not in twig ? )

---------------------------------------------------------------------------

by stof at 2012-05-13T18:08:36Z

@lyrixx When I said it was done previously, I was talking about Twig itself, not about Silex.

---------------------------------------------------------------------------

by lyrixx at 2012-05-13T19:32:38Z

@stof ah ok ;) i did not understood that. But if this PR could be merge, it could be usefull.  We need feedback here ?!