• Fabien Potencier's avatar
    merged branch mageekguy/master (PR #471) · 52c6480b
    Fabien Potencier authored
    Commits
    -------
    
    6d3e410b Use $app['db'] instead of $conn and add autoinc
    
    Discussion
    ----------
    
    Use $app['db’] instead of $conn and add an auto increment
    
    `$conn` is not `$this->conn`and is identical to `$app['db'].
    Moreover, column `id` must be auto-increment.
    
    ---------------------------------------------------------------------------
    
    by igorw at 2012-08-28T13:08:50Z
    
    Apart from that thing, looks good. 👍
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-08-29T13:06:24Z
    
    Can you squash your commits before I merge? Thanks.
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-29T19:55:15Z
    
    @mageekguy when squashing, you need to force the push after that. Here, you merged your remote branch, meaning you kept all the older commits as well.
    
    ---------------------------------------------------------------------------
    
    by mageekguy at 2012-08-29T20:06:49Z
    
    Know it, but my push was refused because not fast-forward.
    So i pull and push, with this result.
    And i don't kown what to do know :/.
    
    ---------------------------------------------------------------------------
    
    by igorw at 2012-08-29T20:32:21Z
    
    You need to force push. Like this: `git push --force origin master`.
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-29T23:24:27Z
    
    @mageekguy not being a fast-forward is expected when squashing as you are rewriting the history.
    
    And in such case, git tells you about both solutions (merging and forcing the push). You choose the wrong one :)
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-30T09:42:38Z
    
    hmm, looks like you messed something when rebasing
    
    ---------------------------------------------------------------------------
    
    by mageekguy at 2012-08-30T11:13:46Z
    
    Seems to be ok now.
    Can you confirm ?
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-30T11:14:28Z
    
    you still have 2 unrelated commits in the branch
    
    ---------------------------------------------------------------------------
    
    by igorw at 2012-08-30T11:51:14Z
    
    Now you need to fix that whitespace issue and it should be mergeable. :)
    
    ---------------------------------------------------------------------------
    
    by igorw at 2012-08-30T12:48:02Z
    
    Alright, now it looks good.
    52c6480b
Name
Last commit
Last update
bin Loading commit data...
doc Loading commit data...
src/Silex Loading commit data...
tests Loading commit data...
.gitignore Loading commit data...
.travis.yml Loading commit data...
LICENSE Loading commit data...
README.md Loading commit data...
composer.json Loading commit data...
composer.lock Loading commit data...
phpunit.xml.dist Loading commit data...