• Fabien Potencier's avatar
    minor #1539 Handle the ControllerResolverInterface::getArguments deprecation in tests (skalpa) · 5c3ca119
    Fabien Potencier authored
    This PR was merged into the 2.2.x-dev branch.
    
    Discussion
    ----------
    
    Handle the ControllerResolverInterface::getArguments deprecation in tests
    
    Fixes deprecation notices/failures due to the deprecation of `ControllerResolverInterface::getArguments()`:
    
    1. `Silex\ControllerResolver` [is not used by Silex](https://github.com/silexphp/Silex/blob/master/src/Silex/Provider/HttpKernelServiceProvider.php#L37) when using HttpKernel >= 3.1.0, so I skipped the only test present in `ControllerResolverTest` with recent versions, as it failed when testing against HttpKernel v4  (master).
    
    2. `ServiceControllerResolverTest::testShouldDelegateGetArguments()` only asserts that the deprecated method is called, so added a `@group legacy` to handle the notice, and skipped the test with v4 to prevent a warning (PHPUnit complains when you mock a non-existent method).
    
    Commits
    -------
    
    c020cec4 Correctly handle the ControllerResolverInterface::getArguments deprecation in tests
    5c3ca119
Name
Last commit
Last update
doc Loading commit data...
src/Silex Loading commit data...
tests/Silex/Tests Loading commit data...
.gitignore Loading commit data...
.travis.yml Loading commit data...
LICENSE Loading commit data...
README.rst Loading commit data...
composer.json Loading commit data...
phpunit.xml.dist Loading commit data...