• Fabien Potencier's avatar
    merged branch marijn/feature/constructor-parameters (PR #556) · 6f9cca8b
    Fabien Potencier authored
    This PR was merged into the master branch.
    
    Commits
    -------
    
    6543379c Allow constructor arguments.
    
    Discussion
    ----------
    
    Allow constructor arguments.
    
    Unfortunately my phpunit installation is horribly broken so I can't run the tests right now...
    
    ---------------------------------------------------------------------------
    
    by igorw at 2012-11-27T00:21:38Z
    
    👍
    
    ---------------------------------------------------------------------------
    
    by igorw at 2012-11-27T00:21:49Z
    
    Docs?
    
    ---------------------------------------------------------------------------
    
    by igorw at 2012-11-27T00:24:24Z
    
    The parent constructor should probably be called at the end, that allows parameters to override the default services. And you should add a test case for that too.
    
    ---------------------------------------------------------------------------
    
    by GromNaN at 2012-11-27T07:54:31Z
    
    @igorw The parent constructor replaces everything, so it cannot be called at the end.
    https://github.com/fabpot/Pimple/blob/master/lib/Pimple.php#L46
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2013-01-03T08:10:28Z
    
    What about just calling `array_replace($this->values, $values)` at the end of the constructor instead?
    
    ---------------------------------------------------------------------------
    
    by igorw at 2013-01-03T08:35:02Z
    
    Sounds good to me.
    6f9cca8b
Name
Last commit
Last update
bin Loading commit data...
doc Loading commit data...
src/Silex Loading commit data...
tests Loading commit data...
.gitignore Loading commit data...
.travis.yml Loading commit data...
LICENSE Loading commit data...
README.md Loading commit data...
composer.json Loading commit data...
phpunit.xml.dist Loading commit data...