• Fabien Potencier's avatar
    merged branch jeremyFreeAgent/register (PR #603) · b42bc687
    Fabien Potencier authored
    This PR was merged into the master branch.
    
    Commits
    -------
    
    11fda10c Updated Application register and mount methods to return Application
    
    Discussion
    ----------
    
    Updated Application register and mount methods to return Application
    
    ---------------------------------------------------------------------------
    
    by jeremyFreeAgent at 2013-01-21T17:43:08Z
    
    Thanky @igorw, I've fixed that.
    
    ---------------------------------------------------------------------------
    
    by igorw at 2013-01-21T17:44:15Z
    
    I'm not opposed to this, but if we add it for `register` we should also do it for `mount` imo.
    
    ---------------------------------------------------------------------------
    
    by jeremyFreeAgent at 2013-01-21T17:44:18Z
    
    You were faster than @stof on that one!
    
    ---------------------------------------------------------------------------
    
    by jeremyFreeAgent at 2013-01-21T17:48:03Z
    
    Yes, for `mount` too... Do I add it ?
    
    ---------------------------------------------------------------------------
    
    by igorw at 2013-01-21T18:49:33Z
    
    You can add it as a separate commit. If we decide that it is not needed for `mount`, you can rebase that commit out ;-)
    
    ---------------------------------------------------------------------------
    
    by jeremyFreeAgent at 2013-01-21T23:17:50Z
    
    I've pushed it in the PR #604.
    
    ---------------------------------------------------------------------------
    
    by jeremyFreeAgent at 2013-01-22T10:15:19Z
    
    Is that better this way?
    
    ---------------------------------------------------------------------------
    
    by igorw at 2013-01-22T14:09:29Z
    
    I would have two tests in the ApplicationTest: `testRegisterShouldReturnSelf`, `testMountShouldReturnSelf`.
    
    ---------------------------------------------------------------------------
    
    by jeremyFreeAgent at 2013-01-22T14:17:21Z
    
    Done!
    b42bc687
Name
Last commit
Last update
bin Loading commit data...
doc Loading commit data...
src/Silex Loading commit data...
tests Loading commit data...
.gitignore Loading commit data...
.travis.yml Loading commit data...
LICENSE Loading commit data...
README.md Loading commit data...
composer.json Loading commit data...
phpunit.xml.dist Loading commit data...