• Fabien Potencier's avatar
    merged branch vicb/sendfile (PR #621) · bcf9678a
    Fabien Potencier authored
    This PR was merged into the master branch.
    
    Commits
    -------
    
    46e6e283 [Doc] Fix references to Symfony 2.0
    9eb3b9b2 [Doc] Document Application::sendFile()
    570df9d4 implement feedback
    734d5738 [Application] Add the ability to send files
    
    Discussion
    ----------
    
    [Application] Add the ability to send files
    
    ---------------------------------------------------------------------------
    
    by GromNaN at 2013-02-06T17:10:24Z
    
    Nice feature 👍
    
    As the `->json` method creates a `JsonResponse`, for consistency the method that create a `BinaryFileResponse` should be named `->binaryFile`.
    
    ---------------------------------------------------------------------------
    
    by vicb at 2013-02-06T17:14:43Z
    
    I deeply love consistency but I really can't be consistent with a method named `json` !
    
    ---------------------------------------------------------------------------
    
    by vicb at 2013-02-06T18:01:40Z
    
    @igorw will do thanks.
    
    i have also warneed f&j about the test result, subtree split ?
    
    ---------------------------------------------------------------------------
    
    by vicb at 2013-02-07T10:29:07Z
    
    @igorw thanks for the feedback, all should be fixed.
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2013-02-07T11:26:50Z
    
    Can you add a note in the documentation about this new feature?
    
    ---------------------------------------------------------------------------
    
    by vicb at 2013-02-07T12:15:10Z
    
    @fabpot, the doc has been updated
    
    ---------------------------------------------------------------------------
    
    by vicb at 2013-02-07T12:23:10Z
    
    @fabpot did you get my email regarding the issue with the tests (sub-stree split ?).
    
    ---------------------------------------------------------------------------
    
    by igorw at 2013-02-07T15:45:09Z
    
    Looks good to me. 👍
    bcf9678a
Name
Last commit
Last update
bin Loading commit data...
doc Loading commit data...
src/Silex Loading commit data...
tests Loading commit data...
.gitignore Loading commit data...
.travis.yml Loading commit data...
LICENSE Loading commit data...
README.md Loading commit data...
composer.json Loading commit data...
phpunit.xml.dist Loading commit data...