• Fabien Potencier's avatar
    minor #1539 Handle the ControllerResolverInterface::getArguments deprecation in tests (skalpa) · 5c3ca119
    Fabien Potencier authored
    This PR was merged into the 2.2.x-dev branch.
    
    Discussion
    ----------
    
    Handle the ControllerResolverInterface::getArguments deprecation in tests
    
    Fixes deprecation notices/failures due to the deprecation of `ControllerResolverInterface::getArguments()`:
    
    1. `Silex\ControllerResolver` [is not used by Silex](https://github.com/silexphp/Silex/blob/master/src/Silex/Provider/HttpKernelServiceProvider.php#L37) when using HttpKernel >= 3.1.0, so I skipped the only test present in `ControllerResolverTest` with recent versions, as it failed when testing against HttpKernel v4  (master).
    
    2. `ServiceControllerResolverTest::testShouldDelegateGetArguments()` only asserts that the deprecated method is called, so added a `@group legacy` to handle the notice, and skipped the test with v4 to prevent a warning (PHPUnit complains when you mock a non-existent method).
    
    Commits
    -------
    
    c020cec4 Correctly handle the ControllerResolverInterface::getArguments deprecation in tests
    5c3ca119
Name
Last commit
Last update
..
Application Loading commit data...
EventListener Loading commit data...
Fixtures Loading commit data...
Provider Loading commit data...
Route Loading commit data...
ApplicationTest.php Loading commit data...
CallbackResolverTest.php Loading commit data...
CallbackServicesTest.php Loading commit data...
ControllerCollectionTest.php Loading commit data...
ControllerResolverTest.php Loading commit data...
ControllerTest.php Loading commit data...
ExceptionHandlerTest.php Loading commit data...
FunctionalTest.php Loading commit data...
JsonTest.php Loading commit data...
LazyDispatcherTest.php Loading commit data...
LazyRequestMatcherTest.php Loading commit data...
LocaleTest.php Loading commit data...
MiddlewareTest.php Loading commit data...
RouterTest.php Loading commit data...
ServiceControllerResolverRouterTest.php Loading commit data...
ServiceControllerResolverTest.php Loading commit data...
StreamTest.php Loading commit data...
WebTestCaseTest.php Loading commit data...