Merge pull request #348 from basdenooijer/develop

Exact null comparisons

library/Solarium/Core/Client/Adapter/Zend2Http.php

@@ -140,7 +140,7 @@ class Zend2Http extends Configurable implements AdapterInterface
      */
     public function getZendHttp()
     {
-        if (null == $this->zendHttp) {
+        if (null === $this->zendHttp) {
             $options = array();
 
             // forward zendhttp options

library/Solarium/Core/Client/Adapter/ZendHttp.php

@@ -142,7 +142,7 @@ class ZendHttp extends Configurable implements AdapterInterface
      */
     public function getZendHttp()
     {
-        if (null == $this->zendHttp) {
+        if (null === $this->zendHttp) {
             $options = array();
 
             // forward zendhttp options

library/Solarium/Core/Client/Client.php

@@ -283,7 +283,7 @@ class Client extends Configurable
             $this->endpoints[$key] = $endpoint;
 
             // if no default endpoint is set do so now
-            if (null == $this->defaultEndpoint) {
+            if (null === $this->defaultEndpoint) {
                 $this->defaultEndpoint = $key;
             }
         }
@@ -323,7 +323,7 @@ class Client extends Configurable
      */
     public function getEndpoint($key = null)
     {
-        if (null == $key) {
+        if (null === $key) {
             $key = $this->defaultEndpoint;
         }
 

library/Solarium/Core/Client/Response.php

@@ -149,7 +149,7 @@ class Response
             }
         }
 
-        if (null == $statusHeader) {
+        if (null === $statusHeader) {
             throw new HttpException("No HTTP status found");
         }
 

library/Solarium/Core/Query/Result/Result.php

@@ -145,7 +145,7 @@ class Result implements ResultInterface
      */
     public function getData()
     {
-        if (null == $this->data) {
+        if (null === $this->data) {
             switch ($this->query->getResponseWriter()) {
                 case AbstractQuery::WT_PHPS:
                     $this->data = unserialize($this->response->getBody());

library/Solarium/Plugin/CustomizeRequest/Customization.php

@@ -227,7 +227,7 @@ class Customization extends Configurable
             return false;
         }
 
-        if (null == $this->getKey() || null == $this->getName() || null == $this->getValue()) {
+        if (null === $this->getKey() || null === $this->getName() || null === $this->getValue()) {
             return false;
         }
 

library/Solarium/Plugin/MinimumScoreFilter/QueryGroupResult.php

@@ -83,7 +83,7 @@ class QueryGroupResult extends StandardQueryGroupResult
         $this->filterRatio = $query->getFilterRatio();
 
         // Use the maximumScore of the first group as maximum for all groups
-        if (self::$overallMaximumScore == null) {
+        if (self::$overallMaximumScore === null) {
             self::$overallMaximumScore = $maximumScore;
         }
 

library/Solarium/Plugin/ParallelExecution/ParallelExecution.php

@@ -92,7 +92,7 @@ class ParallelExecution extends AbstractPlugin
             $endpoint = $endpoint->getKey();
         }
 
-        if ($endpoint == null) {
+        if ($endpoint === null) {
             $endpoint = $this->client->getEndpoint()->getKey();
         }
 

library/Solarium/Plugin/PrefetchIterator.php

@@ -179,7 +179,7 @@ class PrefetchIterator extends AbstractPlugin implements \Iterator, \Countable
     public function count()
     {
         // if no results are available yet, get them now
-        if (null == $this->result) {
+        if (null === $this->result) {
             $this->fetchNext();
         }
 
@@ -239,7 +239,7 @@ class PrefetchIterator extends AbstractPlugin implements \Iterator, \Countable
         $adjustedIndex = $this->position % $this->options['prefetch'];
 
         // this condition prevent useless re-fetching of data if a count is done before the iterator is used
-        if ($adjustedIndex == 0 && ($this->position !== 0 || null == $this->result)) {
+        if ($adjustedIndex === 0 && ($this->position !== 0 || null === $this->result)) {
             $this->fetchNext();
         }
 

library/Solarium/QueryType/Select/Query/Component/MoreLikeThis.php

@@ -111,7 +111,7 @@ class MoreLikeThis extends AbstractComponent
     public function getFields()
     {
         $fields = $this->getOption('fields');
-        if ($fields == null) {
+        if ($fields === null) {
             $fields = array();
         }
 
@@ -320,7 +320,7 @@ class MoreLikeThis extends AbstractComponent
     public function getQueryFields()
     {
         $queryfields = $this->getOption('queryfields');
-        if ($queryfields == null) {
+        if ($queryfields === null) {
             $queryfields = array();
         }
 

library/Solarium/QueryType/Update/Query/Document/Document.php

@@ -225,7 +225,7 @@ class Document extends AbstractDocument implements DocumentInterface
      */
     public function setField($key, $value, $boost = null, $modifier = null)
     {
-        if ($value === null && $modifier == null) {
+        if ($value === null && $modifier === null) {
             $this->removeField($key);
         } else {
             if ($this->filterControlCharacters && is_string($value)) {
@@ -435,7 +435,7 @@ class Document extends AbstractDocument implements DocumentInterface
      */
     public function getFields()
     {
-        if (count($this->modifiers) > 0 && ($this->key == null || !isset($this->fields[$this->key]))) {
+        if (count($this->modifiers) > 0 && ($this->key === null || !isset($this->fields[$this->key]))) {
             throw new RuntimeException(
                 'A document that uses modifiers (atomic updates) must have a key defined before it is used'
             );