Commit 1bb6ec64 authored by Bas de Nooijer's avatar Bas de Nooijer

- small bugfixes and unittest improvements

parent ad85fa03
...@@ -178,7 +178,7 @@ class Solarium_Client_Response_Select extends Solarium_Client_Response ...@@ -178,7 +178,7 @@ class Solarium_Client_Response_Select extends Solarium_Client_Response
$documentClass = $this->_query->getOption('documentclass'); $documentClass = $this->_query->getOption('documentclass');
$searchResults = $this->_data['moreLikeThis']; $searchResults = $this->_data['moreLikeThis'];
foreach($searchResults AS $key => $result) { foreach ($searchResults AS $key => $result) {
// create document instances // create document instances
$docs = array(); $docs = array();
......
...@@ -85,7 +85,7 @@ class Solarium_Query_Select_Component_MoreLikeThis ...@@ -85,7 +85,7 @@ class Solarium_Query_Select_Component_MoreLikeThis
*/ */
public function setFields($fields) public function setFields($fields)
{ {
return $this->_setOption('fields',$fields); return $this->_setOption('fields', $fields);
} }
/** /**
...@@ -109,7 +109,7 @@ class Solarium_Query_Select_Component_MoreLikeThis ...@@ -109,7 +109,7 @@ class Solarium_Query_Select_Component_MoreLikeThis
*/ */
public function setMinimumTermFrequency($minimum) public function setMinimumTermFrequency($minimum)
{ {
return $this->_setOption('minimumtermfrequency',$minimum); return $this->_setOption('minimumtermfrequency', $minimum);
} }
/** /**
...@@ -133,7 +133,7 @@ class Solarium_Query_Select_Component_MoreLikeThis ...@@ -133,7 +133,7 @@ class Solarium_Query_Select_Component_MoreLikeThis
*/ */
public function setMinimumDocumentFrequency($minimum) public function setMinimumDocumentFrequency($minimum)
{ {
return $this->_setOption('minimumdocumentfrequency',$minimum); return $this->_setOption('minimumdocumentfrequency', $minimum);
} }
/** /**
...@@ -156,7 +156,7 @@ class Solarium_Query_Select_Component_MoreLikeThis ...@@ -156,7 +156,7 @@ class Solarium_Query_Select_Component_MoreLikeThis
*/ */
public function setMinimumWordLength($minimum) public function setMinimumWordLength($minimum)
{ {
return $this->_setOption('minimumwordlength',$minimum); return $this->_setOption('minimumwordlength', $minimum);
} }
/** /**
...@@ -179,7 +179,7 @@ class Solarium_Query_Select_Component_MoreLikeThis ...@@ -179,7 +179,7 @@ class Solarium_Query_Select_Component_MoreLikeThis
*/ */
public function setMaximumWordLength($maximum) public function setMaximumWordLength($maximum)
{ {
return $this->_setOption('maximumwordlength',$maximum); return $this->_setOption('maximumwordlength', $maximum);
} }
/** /**
...@@ -203,7 +203,7 @@ class Solarium_Query_Select_Component_MoreLikeThis ...@@ -203,7 +203,7 @@ class Solarium_Query_Select_Component_MoreLikeThis
*/ */
public function setMaximumQueryTerms($maximum) public function setMaximumQueryTerms($maximum)
{ {
return $this->_setOption('maximumqueryterms',$maximum); return $this->_setOption('maximumqueryterms', $maximum);
} }
/** /**
...@@ -227,7 +227,7 @@ class Solarium_Query_Select_Component_MoreLikeThis ...@@ -227,7 +227,7 @@ class Solarium_Query_Select_Component_MoreLikeThis
*/ */
public function setMaximumNumberOfTokens($maximum) public function setMaximumNumberOfTokens($maximum)
{ {
return $this->_setOption('maximumnumberoftokens',$maximum); return $this->_setOption('maximumnumberoftokens', $maximum);
} }
/** /**
...@@ -250,7 +250,7 @@ class Solarium_Query_Select_Component_MoreLikeThis ...@@ -250,7 +250,7 @@ class Solarium_Query_Select_Component_MoreLikeThis
*/ */
public function setBoost($boost) public function setBoost($boost)
{ {
return $this->_setOption('boost',$boost); return $this->_setOption('boost', $boost);
} }
/** /**
...@@ -276,7 +276,7 @@ class Solarium_Query_Select_Component_MoreLikeThis ...@@ -276,7 +276,7 @@ class Solarium_Query_Select_Component_MoreLikeThis
*/ */
public function setQueryFields($queryFields) public function setQueryFields($queryFields)
{ {
return $this->_setOption('queryfields',$queryFields); return $this->_setOption('queryfields', $queryFields);
} }
/** /**
......
...@@ -67,6 +67,14 @@ class Solarium_Result_Select_MoreLikeThisTest extends PHPUnit_Framework_TestCase ...@@ -67,6 +67,14 @@ class Solarium_Result_Select_MoreLikeThisTest extends PHPUnit_Framework_TestCase
); );
} }
public function testGetInvalidResult()
{
$this->assertEquals(
null,
$this->_mlt->getResult('invalid')
);
}
public function testIterator() public function testIterator()
{ {
$items = array(); $items = array();
...@@ -78,4 +86,9 @@ class Solarium_Result_Select_MoreLikeThisTest extends PHPUnit_Framework_TestCase ...@@ -78,4 +86,9 @@ class Solarium_Result_Select_MoreLikeThisTest extends PHPUnit_Framework_TestCase
$this->assertEquals($this->_results, $items); $this->assertEquals($this->_results, $items);
} }
public function testCount()
{
$this->assertEquals(count($this->_results), count($this->_mlt));
}
} }
...@@ -97,6 +97,14 @@ class Solarium_Result_SelectTest extends Solarium_Result_QueryTest ...@@ -97,6 +97,14 @@ class Solarium_Result_SelectTest extends Solarium_Result_QueryTest
); );
} }
public function testGetInvalidComponent()
{
$this->assertEquals(
null,
$this->_result->getComponent('invalid')
);
}
public function testGetMoreLikeThis() public function testGetMoreLikeThis()
{ {
$this->assertEquals( $this->assertEquals(
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment