1. 26 Feb, 2013 1 commit
    • Igor Wiedler's avatar
      Make travis pass on Symfony 2.2 · 337a92c4
      Igor Wiedler authored
      Make travis actually update the lock file and install the 2.2 components.
      Document deprecation of getClassMetadata in validator docs.
      337a92c4
  2. 13 Feb, 2013 2 commits
    • Fabien Potencier's avatar
      merged branch GromNaN/dbal-logger (PR #632) · c421eab3
      Fabien Potencier authored
      This PR was merged into the master branch.
      
      Commits
      -------
      
      fbffc2b0 Enable logger and stopwatch for Doctrine queries
      
      Discussion
      ----------
      
      Add logger and stopwatch for Doctrine queries
      
      Add SQL queries to the logs using the DbalLogger of the DoctrineBridge.
      
      In addition, if the WebprofilerServiceProvider is registered (stopwatch service set), the timeline show doctrine queries.
      
      ![Profiler](https://f.cloud.github.com/assets/400034/152414/877dc396-75c4-11e2-96df-6dde93c7d86e.png)
      
      ---------------------------------------------------------------------------
      
      by DerManoMann at 2013-02-13T10:37:42Z
      
      👍
      
      ---------------------------------------------------------------------------
      
      by fabpot at 2013-02-13T10:39:34Z
      
      I'm wondering if the stopwatch service should be moved to Silex core.
      
      ---------------------------------------------------------------------------
      
      by lyrixx at 2013-02-13T11:05:00Z
      
      Totally 👍 for moving it to silex.
      
      ---------------------------------------------------------------------------
      
      by GromNaN at 2013-02-13T11:16:20Z
      
      Is there a use case for the "stopwatch" outside of the webprofiler ?
      
      ---------------------------------------------------------------------------
      
      by lyrixx at 2013-02-13T11:23:44Z
      
      @GromNaN Yes, it you want to bench some code.
      
      ---------------------------------------------------------------------------
      
      by henrikbjorn at 2013-02-13T11:35:28Z
      
      @fabpot please not it will only add cruft. i think it is a niche thing to use the Stopwatch component.
      c421eab3
    • Jerome TAMARELLE's avatar
      fbffc2b0
  3. 12 Feb, 2013 2 commits
  4. 11 Feb, 2013 5 commits
    • Fabien Potencier's avatar
      merged branch spectralsun/master (PR #617) · eb15c4b4
      Fabien Potencier authored
      This PR was merged into the master branch.
      
      Commits
      -------
      
      ef85340f Fixed brace and spaces
      6ec11533 Changed Assert\MinLength to Assert\Length in doc
      
      Discussion
      ----------
      
      Removed Assert\minLength in doc
      
      Changed to Assert\Length
      
      ---------------------------------------------------------------------------
      
      by igorw at 2013-02-05T00:10:22Z
      
      For the record, this change is due to Assert\MinLength and MaxLength being deprecated in 2.1, in favour of Length.
      
      ---------------------------------------------------------------------------
      
      by igorw at 2013-02-05T00:16:47Z
      
      👍
      
      ---------------------------------------------------------------------------
      
      by fabpot at 2013-02-07T11:22:31Z
      
      As we still support 2.1 and 2.2, I would suggest to add a note to indicate the name of the constraint in 2.1.
      
      ---------------------------------------------------------------------------
      
      by igorw at 2013-02-11T14:23:51Z
      
      @fabpot Length is already available in 2.1. There is no reason not to use it already. This PR looks good to me.
      eb15c4b4
    • Fabien Potencier's avatar
      merged branch igorw/put-delete-example (PR #629) · 28e87dac
      Fabien Potencier authored
      This PR was merged into the master branch.
      
      Commits
      -------
      
      e055ed3e [docs] Add code examples for PUT and DELETE routes
      
      Discussion
      ----------
      
      [docs] Add code examples for PUT and DELETE routes
      28e87dac
    • Fabien Potencier's avatar
      merged branch igorw/route-no-verbs (PR #630) · 34e3e75b
      Fabien Potencier authored
      This PR was merged into the master branch.
      
      Commits
      -------
      
      1e2655f4 Remove the "show" verb from example routes names
      
      Discussion
      ----------
      
      [docs] Remove the "show" verb from example routes names
      
      This changes all examples from /blog/show/{id} to /blog/{id}. This makes
      more sense in terms of HTTP, since the HTTP methods are the verbs and
      the URL represents a resource.
      34e3e75b
    • Igor Wiedler's avatar
      Remove the "show" verb from example routes names · 1e2655f4
      Igor Wiedler authored
      This changes all examples from /blog/show/{id} to /blog/{id}. This makes
      more sense in terms of HTTP, since the HTTP methods are the verbs and
      the URL represents a resource.
      1e2655f4
    • Igor Wiedler's avatar
      e055ed3e
  5. 09 Feb, 2013 1 commit
    • Fabien Potencier's avatar
      merged branch igorw/vendor-check (PR #626) · c2ac686e
      Fabien Potencier authored
      This PR was merged into the master branch.
      
      Commits
      -------
      
      3a5d992c Replace individual test suite component checks with global one
      
      Discussion
      ----------
      
      Replace individual test suite component checks with global one
      
      ---------------------------------------------------------------------------
      
      by davedevelopment at 2013-02-09T19:43:06Z
      
      👍 nice to see code disappearing
      c2ac686e
  6. 08 Feb, 2013 4 commits
  7. 07 Feb, 2013 10 commits
    • Fabien Potencier's avatar
      fixed CS · e69e9f00
      Fabien Potencier authored
      e69e9f00
    • Fabien Potencier's avatar
      merged branch vicb/sendfile (PR #621) · bcf9678a
      Fabien Potencier authored
      This PR was merged into the master branch.
      
      Commits
      -------
      
      46e6e283 [Doc] Fix references to Symfony 2.0
      9eb3b9b2 [Doc] Document Application::sendFile()
      570df9d4 implement feedback
      734d5738 [Application] Add the ability to send files
      
      Discussion
      ----------
      
      [Application] Add the ability to send files
      
      ---------------------------------------------------------------------------
      
      by GromNaN at 2013-02-06T17:10:24Z
      
      Nice feature 👍
      
      As the `->json` method creates a `JsonResponse`, for consistency the method that create a `BinaryFileResponse` should be named `->binaryFile`.
      
      ---------------------------------------------------------------------------
      
      by vicb at 2013-02-06T17:14:43Z
      
      I deeply love consistency but I really can't be consistent with a method named `json` !
      
      ---------------------------------------------------------------------------
      
      by vicb at 2013-02-06T18:01:40Z
      
      @igorw will do thanks.
      
      i have also warneed f&j about the test result, subtree split ?
      
      ---------------------------------------------------------------------------
      
      by vicb at 2013-02-07T10:29:07Z
      
      @igorw thanks for the feedback, all should be fixed.
      
      ---------------------------------------------------------------------------
      
      by fabpot at 2013-02-07T11:26:50Z
      
      Can you add a note in the documentation about this new feature?
      
      ---------------------------------------------------------------------------
      
      by vicb at 2013-02-07T12:15:10Z
      
      @fabpot, the doc has been updated
      
      ---------------------------------------------------------------------------
      
      by vicb at 2013-02-07T12:23:10Z
      
      @fabpot did you get my email regarding the issue with the tests (sub-stree split ?).
      
      ---------------------------------------------------------------------------
      
      by igorw at 2013-02-07T15:45:09Z
      
      Looks good to me. 👍
      bcf9678a
    • Victor's avatar
      [Doc] Fix references to Symfony 2.0 · 46e6e283
      Victor authored
      46e6e283
    • Victor's avatar
      [Doc] Document Application::sendFile() · 9eb3b9b2
      Victor authored
      9eb3b9b2
    • Fabien Potencier's avatar
      merged branch igorw/provider-param-convention (PR #622) · cbeadaff
      Fabien Potencier authored
      This PR was merged into the master branch.
      
      Commits
      -------
      
      3eaa38cf Clarify provider conventions for params
      
      Discussion
      ----------
      
      Clarify provider conventions for params
      
      The current conventions for parameters is outdated. At some point we
      decided that providers can define default values for params. Therefore
      parameters must be registered *after* the extension is registered.
      
      Related commit: 9766faf0
      cbeadaff
    • Fabien Potencier's avatar
      merged branch vicb/doc (PR #619) · 7fe94866
      Fabien Potencier authored
      This PR was merged into the master branch.
      
      Commits
      -------
      
      79d40aed implement feedback
      4e36a6a4 doc tweaks
      
      Discussion
      ----------
      
      minor doc tweaks
      
      ---------------------------------------------------------------------------
      
      by vicb at 2013-02-07T10:30:20Z
      
      @igorw fixed, thanks.
      7fe94866
    • Fabien Potencier's avatar
      merged branch GromNaN/patch-9 (PR #618) · 9a210c05
      Fabien Potencier authored
      This PR was merged into the master branch.
      
      Commits
      -------
      
      96e71626 [doc] Scope consistency with previous example
      
      Discussion
      ----------
      
      [doc] Consistency with previous example
      
      ---------------------------------------------------------------------------
      
      by igorw at 2013-02-06T18:00:25Z
      
      👍
      9a210c05
    • Victor's avatar
      implement feedback · 570df9d4
      Victor authored
      570df9d4
    • Victor's avatar
      implement feedback · 79d40aed
      Victor authored
      79d40aed
    • Igor Wiedler's avatar
      Clarify provider conventions for params · 3eaa38cf
      Igor Wiedler authored
      The current conventions for parameters is outdated. At some point we
      decided that providers can define default values for params. Therefore
      parameters must be registered *after* the extension is registered.
      
      Related commit: 9766faf0
      3eaa38cf
  8. 06 Feb, 2013 3 commits
  9. 05 Feb, 2013 5 commits
    • Fabien Potencier's avatar
      merged branch igorw/constraints-docs (PR #616) · 22a8fea7
      Fabien Potencier authored
      This PR was merged into the master branch.
      
      Commits
      -------
      
      64b66b13 [docs] Adjust symfony/* constraints to use tilde operator
      
      Discussion
      ----------
      
      [docs] Adjust symfony/* constraints to use tilde operator
      
      This will hopefully make upgrade to 2.2 more seamless
      22a8fea7
    • Fabien Potencier's avatar
      merged branch srsbiz/master (PR #574) · 213ceb20
      Fabien Potencier authored
      This PR was squashed before being merged into the master branch (closes #574).
      
      Commits
      -------
      
      8c2b5755 OS independent regexp in Monolog test case
      
      Discussion
      ----------
      
      OS independent regexp in Monolog test case
      
      Minor correction to make this test case pass on Windows
      
      ---------------------------------------------------------------------------
      
      by igorw at 2013-01-05T17:11:05Z
      
      Maybe just change the test to check for `very bad error` - seems less messy.
      
      ---------------------------------------------------------------------------
      
      by davedevelopment at 2013-01-06T20:59:30Z
      
      Or just .* the whole path up to the filename
      
      ---------------------------------------------------------------------------
      
      by igorw at 2013-01-06T23:46:14Z
      
      👍
      
      ---------------------------------------------------------------------------
      
      by igorw at 2013-02-05T12:51:31Z
      
      Can we get this merged please? We now have other PRs like #614 duplicating this effort.
      213ceb20
    • srsbiz's avatar
      OS independent regexp in Monolog test case · 8c2b5755
      srsbiz authored
      8c2b5755
    • ver1tas's avatar
      Fixed brace and spaces · ef85340f
      ver1tas authored
      ef85340f
    • ver1tas's avatar
      Changed Assert\MinLength to Assert\Length in doc · 6ec11533
      ver1tas authored
      6ec11533
  10. 04 Feb, 2013 3 commits
  11. 25 Jan, 2013 1 commit
    • Fabien Potencier's avatar
      merged branch hakre/patch-1 (PR #600) · a23c221e
      Fabien Potencier authored
      This PR was merged into the master branch.
      
      Commits
      -------
      
      94685096 Make reason of prenatal code visible.
      
      Discussion
      ----------
      
      Make reason of prenatal code visible.
      
      Code is commented since ages, the reason is missing (because there is a reason).
      
      See #594
      a23c221e
  12. 24 Jan, 2013 3 commits