Commits
-------

c9fb6da5 Remove dependency on the ClassLoader component.

Discussion
----------

Remove dependency on the ClassLoader component.

Commits
-------

28c1b4c1 Added Twig_Extension_Debug if app is in debug mode

Discussion
----------

Added Twig_Extension_Debug if app is in debug mode

---------------------------------------------------------------------------

by stof at 2012-04-16T21:51:12Z

This was done initially in the PR adding it. But it has been reverted to avoid hard-to-debug issues when you have a template containing a dump call (it would work properly in your dev environment but throw an exception in your prod environment)

---------------------------------------------------------------------------

by lyrixx at 2012-05-12T14:12:09Z

@stof but it's very usefull ... more over, every dev add this extension.

---------------------------------------------------------------------------

by stof at 2012-05-12T23:36:27Z

@lyrixx The issue is that if it will be added only in debug mode and you forget to remove a dump call from your template, it will work properly in your dev environment (where Twig will be in debug mode with the extension) whereas the compilation of the template will fail in prod (because the function will not be defined anymore)

---------------------------------------------------------------------------

by lyrixx at 2012-05-13T13:21:20Z

@stof Yes I understood. I did the patch... But every time, on a new projet, I copy/paste these lines to my projet. And I am not the only one. So I think we could add this feature into silex. (And why not in twig ? )

---------------------------------------------------------------------------

by stof at 2012-05-13T18:08:36Z

@lyrixx When I said it was done previously, I was talking about Twig itself, not about Silex.

---------------------------------------------------------------------------

by lyrixx at 2012-05-13T19:32:38Z

@stof ah ok ;) i did not understood that. But if this PR could be merge, it could be usefull.  We need feedback here ?!

* tmp:
  Updated validator doc to show validation in YAML files

Commits
-------

eaf176d3 added a Route class
e3ddad54 added the possibility for settings set on a controller collection to influence controllers register later on
0356873a changed Controller::generateRouteName() visibility
31652440 added a way to define settings for all routes of a collection (closes #186)

Discussion
----------

added a way to define settings for all routes of a collection (closes #186)

see the ticket and docs from the patch.

---------------------------------------------------------------------------

by fabpot at 2012-05-21T13:00:13Z

ok, I've changed the strategy to what I've described above. ping @igorw

---------------------------------------------------------------------------

by igorw at 2012-05-21T16:09:56Z

`ControllerCollection extends Controller` is weird. I see how some code can be re-used, but a controller cannot be frozen or named, so those parts don't really make sense to me.

Apart from that it's a nice feature. If you can come up with a cleaner way to do it that doesn't bloat the code too much, that'd be nice.

---------------------------------------------------------------------------

by fabpot at 2012-05-21T16:30:16Z

What about creating a `Route` class that extends the Symfony `Route` class? It would contain the `assert`, `value`, `requireHttp`, `requireHttps`, `convert`, and `middleware` methods. Then, `Controller` and `ControllerCollection` extend this new `Route` class.

---------------------------------------------------------------------------

by fabpot at 2012-05-21T16:33:23Z

Extending the `Route` is not necessarily a good idea either. What about creating this `Route` class and compose it into both `Controller` and `ControllerCollection`?

---------------------------------------------------------------------------

by fabpot at 2012-05-21T16:33:50Z

That's what my last commit does.

---------------------------------------------------------------------------

by fabpot at 2012-05-21T16:36:34Z

By the way, a Trait would probably have been the best solution.

added the possibility for settings set on a controller collection to influence controllers register later on