- 12 Feb, 2013 1 commit
-
-
Victor authored
-
- 11 Feb, 2013 5 commits
-
-
Fabien Potencier authored
This PR was merged into the master branch. Commits ------- ef85340f Fixed brace and spaces 6ec11533 Changed Assert\MinLength to Assert\Length in doc Discussion ---------- Removed Assert\minLength in doc Changed to Assert\Length --------------------------------------------------------------------------- by igorw at 2013-02-05T00:10:22Z For the record, this change is due to Assert\MinLength and MaxLength being deprecated in 2.1, in favour of Length. --------------------------------------------------------------------------- by igorw at 2013-02-05T00:16:47Z
👍 --------------------------------------------------------------------------- by fabpot at 2013-02-07T11:22:31Z As we still support 2.1 and 2.2, I would suggest to add a note to indicate the name of the constraint in 2.1. --------------------------------------------------------------------------- by igorw at 2013-02-11T14:23:51Z @fabpot Length is already available in 2.1. There is no reason not to use it already. This PR looks good to me. -
Fabien Potencier authored
This PR was merged into the master branch. Commits ------- e055ed3e [docs] Add code examples for PUT and DELETE routes Discussion ---------- [docs] Add code examples for PUT and DELETE routes
-
Fabien Potencier authored
This PR was merged into the master branch. Commits ------- 1e2655f4 Remove the "show" verb from example routes names Discussion ---------- [docs] Remove the "show" verb from example routes names This changes all examples from /blog/show/{id} to /blog/{id}. This makes more sense in terms of HTTP, since the HTTP methods are the verbs and the URL represents a resource.
-
Igor Wiedler authored
This changes all examples from /blog/show/{id} to /blog/{id}. This makes more sense in terms of HTTP, since the HTTP methods are the verbs and the URL represents a resource.
-
Igor Wiedler authored
-
- 09 Feb, 2013 1 commit
-
-
Fabien Potencier authored
This PR was merged into the master branch. Commits ------- 3a5d992c Replace individual test suite component checks with global one Discussion ---------- Replace individual test suite component checks with global one --------------------------------------------------------------------------- by davedevelopment at 2013-02-09T19:43:06Z
👍 nice to see code disappearing
-
- 08 Feb, 2013 4 commits
-
-
Igor Wiedler authored
-
Fabien Potencier authored
This PR was merged into the master branch. Commits ------- 8e11cfa5 [Tests] Make use of the @requires annotation for PHP version 1e0dd622 Fix Doctrine tests Discussion ---------- [Test] Improvements see https://github.com/fabpot/Silex/pull/620
-
Victor authored
-
Victor authored
-
- 07 Feb, 2013 10 commits
-
-
Fabien Potencier authored
-
Fabien Potencier authored
This PR was merged into the master branch. Commits ------- 46e6e283 [Doc] Fix references to Symfony 2.0 9eb3b9b2 [Doc] Document Application::sendFile() 570df9d4 implement feedback 734d5738 [Application] Add the ability to send files Discussion ---------- [Application] Add the ability to send files --------------------------------------------------------------------------- by GromNaN at 2013-02-06T17:10:24Z Nice feature
👍 As the `->json` method creates a `JsonResponse`, for consistency the method that create a `BinaryFileResponse` should be named `->binaryFile`. --------------------------------------------------------------------------- by vicb at 2013-02-06T17:14:43Z I deeply love consistency but I really can't be consistent with a method named `json` ! --------------------------------------------------------------------------- by vicb at 2013-02-06T18:01:40Z @igorw will do thanks. i have also warneed f&j about the test result, subtree split ? --------------------------------------------------------------------------- by vicb at 2013-02-07T10:29:07Z @igorw thanks for the feedback, all should be fixed. --------------------------------------------------------------------------- by fabpot at 2013-02-07T11:26:50Z Can you add a note in the documentation about this new feature? --------------------------------------------------------------------------- by vicb at 2013-02-07T12:15:10Z @fabpot, the doc has been updated --------------------------------------------------------------------------- by vicb at 2013-02-07T12:23:10Z @fabpot did you get my email regarding the issue with the tests (sub-stree split ?). --------------------------------------------------------------------------- by igorw at 2013-02-07T15:45:09Z Looks good to me.👍 -
Victor authored
-
Victor authored
-
Fabien Potencier authored
This PR was merged into the master branch. Commits ------- 3eaa38cf Clarify provider conventions for params Discussion ---------- Clarify provider conventions for params The current conventions for parameters is outdated. At some point we decided that providers can define default values for params. Therefore parameters must be registered *after* the extension is registered. Related commit: 9766faf0
-
Fabien Potencier authored
This PR was merged into the master branch. Commits ------- 79d40aed implement feedback 4e36a6a4 doc tweaks Discussion ---------- minor doc tweaks --------------------------------------------------------------------------- by vicb at 2013-02-07T10:30:20Z @igorw fixed, thanks.
-
Fabien Potencier authored
This PR was merged into the master branch. Commits ------- 96e71626 [doc] Scope consistency with previous example Discussion ---------- [doc] Consistency with previous example --------------------------------------------------------------------------- by igorw at 2013-02-06T18:00:25Z
👍 -
Victor authored
-
Victor authored
-
Igor Wiedler authored
The current conventions for parameters is outdated. At some point we decided that providers can define default values for params. Therefore parameters must be registered *after* the extension is registered. Related commit: 9766faf0
-
- 06 Feb, 2013 3 commits
-
-
Victor authored
-
Victor authored
-
Jérôme Tamarelle authored
-
- 05 Feb, 2013 5 commits
-
-
Fabien Potencier authored
This PR was merged into the master branch. Commits ------- 64b66b13 [docs] Adjust symfony/* constraints to use tilde operator Discussion ---------- [docs] Adjust symfony/* constraints to use tilde operator This will hopefully make upgrade to 2.2 more seamless
-
Fabien Potencier authored
This PR was squashed before being merged into the master branch (closes #574). Commits ------- 8c2b5755 OS independent regexp in Monolog test case Discussion ---------- OS independent regexp in Monolog test case Minor correction to make this test case pass on Windows --------------------------------------------------------------------------- by igorw at 2013-01-05T17:11:05Z Maybe just change the test to check for `very bad error` - seems less messy. --------------------------------------------------------------------------- by davedevelopment at 2013-01-06T20:59:30Z Or just .* the whole path up to the filename --------------------------------------------------------------------------- by igorw at 2013-01-06T23:46:14Z
👍 --------------------------------------------------------------------------- by igorw at 2013-02-05T12:51:31Z Can we get this merged please? We now have other PRs like #614 duplicating this effort. -
srsbiz authored
-
ver1tas authored
-
ver1tas authored
-
- 04 Feb, 2013 3 commits
-
-
Igor Wiedler authored
This will hopefully make upgrade to 2.2 more seamless
-
Fabien Potencier authored
This PR was merged into the master branch. Commits ------- 7c1f6a5c Improve constraints of fat composer.json Discussion ---------- Improve constraints of fat composer.json * Change symfony/* from 2.1.* => ~2.1 * Delegate twig and monolog version selection to bridges
-
Igor Wiedler authored
* Change symfony/* from 2.1.* => ~2.1 * Delegate twig and monolog version selection to bridges
-
- 25 Jan, 2013 1 commit
-
-
Fabien Potencier authored
This PR was merged into the master branch. Commits ------- 94685096 Make reason of prenatal code visible. Discussion ---------- Make reason of prenatal code visible. Code is commented since ages, the reason is missing (because there is a reason). See #594
-
- 24 Jan, 2013 3 commits
-
-
Fabien Potencier authored
This PR was merged into the master branch. Commits ------- 48ec9b11 Make test ignore JSON semantics Discussion ---------- Make test ignore JSON semantics One fix for Symfony 2.2, related to #607 and symfony/symfony#5506
-
Dave Marshall authored
-
Fabien Potencier authored
-
- 23 Jan, 2013 4 commits
-
-
Fabien Potencier authored
This PR was squashed before being merged into the master branch (closes #607). Commits ------- dc8ee5d8 [WIP] Make test suite run against symfony/* 2.2 Discussion ---------- [WIP] Make test suite run against symfony/* 2.2 There are still quite a few tests failing. Feel free to send PRs my way.
-
Igor Wiedler authored
-
Fabien Potencier authored
This PR was squashed before being merged into the master branch (closes #605). Commits ------- b6606a7c Updated HttpCacheServiceProvider documentation Discussion ---------- Updated HttpCacheServiceProvider documentation --------------------------------------------------------------------------- by igorw at 2013-01-23T12:38:25Z
👍 -
Javier Eguiluz authored
-